Skip to content

Remove outliers for mysql and ES query times#8927

Merged
Viper007Bond merged 1 commit intomasterfrom
fix/limit-mysql-log-time
Feb 23, 2018
Merged

Remove outliers for mysql and ES query times#8927
Viper007Bond merged 1 commit intomasterfrom
fix/limit-mysql-log-time

Conversation

@gravityrail
Copy link
Copy Markdown
Contributor

Fixes #8926

Changes proposed in this Pull Request:

  • Only log mysql and ES query times that are less than 60 seconds. There are some outliers that mess up our stats.

Testing instructions:

  • Open the browser's debugger tools
  • Disable Search
  • Run search queries, ?s=foo
  • Check that your network requests include a request like https://pixel.wp.com/boom.gif?(stuff)jetpack.search.mysql(stuff)
  • Do the same with Search enabled, and check that it logs with jetpack.search.es instead of jetpack.search.mysql

If you want to see if logging happens over the query limit, you might need to throttle your connection to public-api.wordpress.com and your local MySQL server. Instructions on how to do so are system-specific, so up to the tester.

@gravityrail gravityrail requested a review from a team as a code owner February 23, 2018 20:02
@gravityrail gravityrail self-assigned this Feb 23, 2018
@gravityrail gravityrail added the [Feature] Search For all things related to Search label Feb 23, 2018
@gravityrail gravityrail modified the milestones: 5.8.1, 5.9 Feb 23, 2018
@gravityrail gravityrail added the [Status] Needs Review This PR is ready for review. label Feb 23, 2018
Copy link
Copy Markdown
Contributor

@Viper007Bond Viper007Bond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM

Copy link
Copy Markdown
Member

@gibrown gibrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Viper007Bond Viper007Bond merged commit 23e0181 into master Feb 23, 2018
@Viper007Bond Viper007Bond deleted the fix/limit-mysql-log-time branch February 23, 2018 22:13
@jeherve jeherve removed the [Status] Needs Review This PR is ready for review. label Feb 24, 2018
oskosk added a commit that referenced this pull request Feb 27, 2018
oskosk added a commit that referenced this pull request Feb 27, 2018
* update changelog.txt

* Update readme.txt with scaffolding for 5.9 changelog and release draft shortlink

* Add changelog entry for #8243

* Add changelog entry for #8296

* Add changelog entry for #8367

* Add changelog entry for #8686

* Add changelog entry for #8707

* Add changelog entry for #8709 and #8714

* Add changelog entry for #8729

* Add changelog entry for #8777

* Add changelog entry for #8780

* Add changelog entry for #8786

* Add changelog entry for #8787

* Add changelog entry for #8801 #8805 #8832 #8865 and #8804

* Add changelog entry for #8817

* Add changelog entry for #8822

* Add changelog entry for #8823

* Add changelog entry for #8829

* Add changelog entry for #8834

* move some items to major enhancements

* Add changelog entry for #8836

* Add changelog entry for #8839

* Add changelog entry for #8861

* Add changelog entry for #8862

* Add changelog entry for #8863

* Add changelog entry for #8866

* Add changelog entry for #8870

* Add changelog entry for #8874

* Add changelog entry for #8875

* Add changelog entry for #8881

* Add changelog entry for #8890

* Add changelog entry for #8911

* Add changelog entry for #8927

* Add changelog entry for #8931

* Add changelog entry for #8933

* Add changelog entry for #8930

* fix wording

* typo

* minor fixes

* replace partner scripts for Jetpack Start in changelog entry

* Update to-test.md

* Update to-test.md

* minor style fixes to to-test.md

* minor style fixes to to-test.md

* minor fixes on to-test.md

* Add changelog entry for #8868

* Add changelog entry for #8844

* Add changelog entry for #8664

* Add changelog entry for #8935

* Add changelog entry for #8425

* Add changelog entry for #8625
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Search For all things related to Search

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants