Skip to content

Markdown: Avoid usage of create_function#8868

Merged
dereksmart merged 2 commits intomasterfrom
remove/create_function-from-markdown-extra
Feb 27, 2018
Merged

Markdown: Avoid usage of create_function#8868
dereksmart merged 2 commits intomasterfrom
remove/create_function-from-markdown-extra

Conversation

@oskosk
Copy link
Copy Markdown
Contributor

@oskosk oskosk commented Feb 17, 2018

Part of #8156.
Alternative to #8869.

Fixes https://wordpress.org/support/topic/deprecated-function-create_function-2/

Changes proposed in this Pull Request:

  • Introduces function jetpack_utf8_strlen.
  • Replaces usage of create_function for jetpack_utf8_strlen in markdown/extra.php.

Note: mb_strlen has been available since PHP 4. Should we drop this conditional usage instead ? This alternative is implemented in #8869. Apparently there's still a chance that a php installation lacks the mbstring extension.

Testing instructions:

Proposed changelog entry for your changes:

  • Removed usage of create_function from markdown module as it's deprecated in PHP 7.2.

@zinigor zinigor added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 27, 2018
Copy link
Copy Markdown
Contributor

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dereksmart dereksmart merged commit 70c39c9 into master Feb 27, 2018
@dereksmart dereksmart deleted the remove/create_function-from-markdown-extra branch February 27, 2018 13:34
oskosk added a commit that referenced this pull request Feb 27, 2018
oskosk added a commit that referenced this pull request Feb 27, 2018
* update changelog.txt

* Update readme.txt with scaffolding for 5.9 changelog and release draft shortlink

* Add changelog entry for #8243

* Add changelog entry for #8296

* Add changelog entry for #8367

* Add changelog entry for #8686

* Add changelog entry for #8707

* Add changelog entry for #8709 and #8714

* Add changelog entry for #8729

* Add changelog entry for #8777

* Add changelog entry for #8780

* Add changelog entry for #8786

* Add changelog entry for #8787

* Add changelog entry for #8801 #8805 #8832 #8865 and #8804

* Add changelog entry for #8817

* Add changelog entry for #8822

* Add changelog entry for #8823

* Add changelog entry for #8829

* Add changelog entry for #8834

* move some items to major enhancements

* Add changelog entry for #8836

* Add changelog entry for #8839

* Add changelog entry for #8861

* Add changelog entry for #8862

* Add changelog entry for #8863

* Add changelog entry for #8866

* Add changelog entry for #8870

* Add changelog entry for #8874

* Add changelog entry for #8875

* Add changelog entry for #8881

* Add changelog entry for #8890

* Add changelog entry for #8911

* Add changelog entry for #8927

* Add changelog entry for #8931

* Add changelog entry for #8933

* Add changelog entry for #8930

* fix wording

* typo

* minor fixes

* replace partner scripts for Jetpack Start in changelog entry

* Update to-test.md

* Update to-test.md

* minor style fixes to to-test.md

* minor style fixes to to-test.md

* minor fixes on to-test.md

* Add changelog entry for #8868

* Add changelog entry for #8844

* Add changelog entry for #8664

* Add changelog entry for #8935

* Add changelog entry for #8425

* Add changelog entry for #8625
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants