Skip to content

Masterbar: Proposal - Do not sign out by default from wpcom when clicking the Sign out link#8243

Merged
oskosk merged 3 commits intomasterfrom
update/do-not-signout-wpcom-by-default-masterbar
Feb 20, 2018
Merged

Masterbar: Proposal - Do not sign out by default from wpcom when clicking the Sign out link#8243
oskosk merged 3 commits intomasterfrom
update/do-not-signout-wpcom-by-default-masterbar

Conversation

@oskosk
Copy link
Copy Markdown
Contributor

@oskosk oskosk commented Nov 24, 2017 •
edited
Loading

This is a proposal so it can be tested with the Jetpack Beta Plugin when the PR finishes being unit-tested by Travis.

Context: p1HpG7-4Fe-p2

Changes proposed in this Pull Request:

  • Adds a filter jetpack_masterbar_should_logout_from_wpcom defaulting to false.
  • Make the value be filtered to true for AT sites.

Testing instructions:

Repeat steps on an AT site but expect to be logged out from WordPress.com in the end.

Changelog entry

We updated the sign out behaviour of the Masterbar to not sign you out of WordPress.com at the same time you sign out of your site.

@oskosk oskosk added [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Status] In Progress labels Nov 24, 2017
@oskosk oskosk requested a review from a team as a code owner November 24, 2017 20:40
@oskosk oskosk force-pushed the update/do-not-signout-wpcom-by-default-masterbar branch from d37015d to 0b5e19e Compare November 24, 2017 20:45
@oskosk
Copy link
Copy Markdown
Contributor Author

oskosk commented Nov 27, 2017

@vindl do you think this would work fine or if it would be desirable according to what was asked in #8173 (comment) ?

Also dropped p1HpG7-4Fe-p2 about this for discussion.

@vindl
Copy link
Copy Markdown
Member

vindl commented Nov 27, 2017

@vindl do you think this would work fine or if it would be desirable according to what was asked in #8173 (comment) ?

@oskosk I think this makes sense and codewise it looks good to me. 👍

@vindl
Copy link
Copy Markdown
Member

vindl commented Nov 27, 2017

/cc Atomic team just in case: @jhnstn @retrofox @donpark.

@oskosk oskosk force-pushed the update/do-not-signout-wpcom-by-default-masterbar branch from 0b5e19e to a092054 Compare November 27, 2017 17:36
@oskosk oskosk added this to the 5.9 milestone Feb 20, 2018
@oskosk oskosk added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 20, 2018
@oskosk
Copy link
Copy Markdown
Contributor Author

oskosk commented Feb 20, 2018

@jhnstn @retrofox @donpark I'm merging this one.

@oskosk oskosk merged commit d7d2041 into master Feb 20, 2018
@oskosk oskosk deleted the update/do-not-signout-wpcom-by-default-masterbar branch February 20, 2018 16:21
@jeherve jeherve added the [Status] Needs Testing We need to add this change to the testing call for this month's release label Feb 20, 2018
oskosk added a commit that referenced this pull request Feb 27, 2018
@oskosk
Add changelog entry for #8243
355b171
oskosk added a commit that referenced this pull request Feb 27, 2018
@oskosk
Changelog 5.9: running changelog (#8819)
1174ef5 
* update changelog.txt

* Update readme.txt with scaffolding for 5.9 changelog and release draft shortlink

* Add changelog entry for #8243

* Add changelog entry for #8296

* Add changelog entry for #8367

* Add changelog entry for #8686

* Add changelog entry for #8707

* Add changelog entry for #8709 and #8714

* Add changelog entry for #8729

* Add changelog entry for #8777

* Add changelog entry for #8780

* Add changelog entry for #8786

* Add changelog entry for #8787

* Add changelog entry for #8801 #8805 #8832 #8865 and #8804

* Add changelog entry for #8817

* Add changelog entry for #8822

* Add changelog entry for #8823

* Add changelog entry for #8829

* Add changelog entry for #8834

* move some items to major enhancements

* Add changelog entry for #8836

* Add changelog entry for #8839

* Add changelog entry for #8861

* Add changelog entry for #8862

* Add changelog entry for #8863

* Add changelog entry for #8866

* Add changelog entry for #8870

* Add changelog entry for #8874

* Add changelog entry for #8875

* Add changelog entry for #8881

* Add changelog entry for #8890

* Add changelog entry for #8911

* Add changelog entry for #8927

* Add changelog entry for #8931

* Add changelog entry for #8933

* Add changelog entry for #8930

* fix wording

* typo

* minor fixes

* replace partner scripts for Jetpack Start in changelog entry

* Update to-test.md

* Update to-test.md

* minor style fixes to to-test.md

* minor style fixes to to-test.md

* minor fixes on to-test.md

* Add changelog entry for #8868

* Add changelog entry for #8844

* Add changelog entry for #8664

* Add changelog entry for #8935

* Add changelog entry for #8425

* Add changelog entry for #8625
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
@jeherve jeherve removed the [Status] Needs Testing We need to add this change to the testing call for this month's release label Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vindl vindl vindl approved these changes

Assignees

No one assigned

Labels

[Feature] Masterbar WordPress.com Toolbar and Dashboard customizations

Projects

None yet

Milestone

5.9

Development

Successfully merging this pull request may close these issues.

5 participants

@oskosk @vindl @kraftbj @jeherve @matticbot