Skip to content

JPO: Delete onboarding token after connecting the site#8933

Merged
dereksmart merged 1 commit intomasterfrom
update/delete-jpo-token-after-connecting
Feb 26, 2018
Merged

JPO: Delete onboarding token after connecting the site#8933
dereksmart merged 1 commit intomasterfrom
update/delete-jpo-token-after-connecting

Conversation

@tyxla
Copy link
Copy Markdown
Member

@tyxla tyxla commented Feb 26, 2018

This PR suggests that we delete the JPO token after a successful connection.

Part of the solution for Automattic/wp-calypso#21680. You can use in conjunction with Automattic/wp-calypso#22763 if you want

To test:

  • Start a fresh JN site with this branch on it (you can do that by loading https://jurassic.ninja/create?jetpack-beta&branch=update/delete-jpo-token-after-connecting)
  • Make sure you are logged into WP.com and the Jetpack site.
  • Start the onboarding flow by going to /wp-admin/admin.php?page=jetpack&action=onboard and get redirected to the site title step in Calypso
  • Open a ssh session for the Jetpack site and verify a wp option get jetpack_onboarding returns the token.
  • Go to https://wordpress.com/jetpack/connect/ and connect the site.
  • Verify a wp option get jetpack_onboarding no longer returns the token.
  • Start another fresh JN site with this branch on it.
  • Without going to the JPO flow, connect the site.
  • Verify there are no errors in the connection process and the site connects successfully.

Changelog entry

  • Delete the onboarding token when the site gets connected.

Copy link
Copy Markdown
Contributor

@ockham ockham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, really appreciate it! Works perfectly fine, :shipit:

Copy link
Copy Markdown
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well! 🚢

@oskosk oskosk added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 26, 2018
@dereksmart dereksmart merged commit b2178b2 into master Feb 26, 2018
@dereksmart dereksmart deleted the update/delete-jpo-token-after-connecting branch February 26, 2018 20:53
@tyxla tyxla removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 27, 2018
oskosk added a commit that referenced this pull request Feb 27, 2018
oskosk added a commit that referenced this pull request Feb 27, 2018
* update changelog.txt

* Update readme.txt with scaffolding for 5.9 changelog and release draft shortlink

* Add changelog entry for #8243

* Add changelog entry for #8296

* Add changelog entry for #8367

* Add changelog entry for #8686

* Add changelog entry for #8707

* Add changelog entry for #8709 and #8714

* Add changelog entry for #8729

* Add changelog entry for #8777

* Add changelog entry for #8780

* Add changelog entry for #8786

* Add changelog entry for #8787

* Add changelog entry for #8801 #8805 #8832 #8865 and #8804

* Add changelog entry for #8817

* Add changelog entry for #8822

* Add changelog entry for #8823

* Add changelog entry for #8829

* Add changelog entry for #8834

* move some items to major enhancements

* Add changelog entry for #8836

* Add changelog entry for #8839

* Add changelog entry for #8861

* Add changelog entry for #8862

* Add changelog entry for #8863

* Add changelog entry for #8866

* Add changelog entry for #8870

* Add changelog entry for #8874

* Add changelog entry for #8875

* Add changelog entry for #8881

* Add changelog entry for #8890

* Add changelog entry for #8911

* Add changelog entry for #8927

* Add changelog entry for #8931

* Add changelog entry for #8933

* Add changelog entry for #8930

* fix wording

* typo

* minor fixes

* replace partner scripts for Jetpack Start in changelog entry

* Update to-test.md

* Update to-test.md

* minor style fixes to to-test.md

* minor style fixes to to-test.md

* minor fixes on to-test.md

* Add changelog entry for #8868

* Add changelog entry for #8844

* Add changelog entry for #8664

* Add changelog entry for #8935

* Add changelog entry for #8425

* Add changelog entry for #8625
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants