Add option to testimonials shortcode to show full testimonial#2815
Merged
dereksmart merged 8 commits intomasterfrom Oct 28, 2015
Merged
Add option to testimonials shortcode to show full testimonial#2815dereksmart merged 8 commits intomasterfrom
dereksmart merged 8 commits intomasterfrom
Conversation
Member
|
If we make that change, it might make sense to do the same thing for the Portfolio shortcode as well, to keep things consistent. |
Contributor
There was a problem hiding this comment.
You'll either need to add a closing php tag here, or omit the opening one in the line below
Contributor
|
talked with @chaselivingston and we're going with a new argument for display_content rather than adding a whole new attribute |
Contributor
There was a problem hiding this comment.
Where does portfolio-entry get closed now?
Contributor
There was a problem hiding this comment.
Looks like it doesn't :/
Contributor
|
👍 Looks good now! |
dereksmart
added a commit
that referenced
this pull request
Oct 28, 2015
Add option to testimonials shortcode to show full testimonial
|
Looked at the php file now and saw: display_content=full. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
show_excerptattribute to thetestimonialsshortcode to give users the option to show the full testimonial. Set totrueby default.Fixes #2814