Skip to content

Wpcom/sync misc 12april2017#6965

Merged
georgestephanis merged 21 commits intomasterfrom
wpcom/sync-misc-12april2017
Apr 21, 2017
Merged

Wpcom/sync misc 12april2017#6965
georgestephanis merged 21 commits intomasterfrom
wpcom/sync-misc-12april2017

Conversation

@georgestephanis
Copy link
Copy Markdown
Contributor

Assorted wpcom changes, work in progress. Will have a better summary before goes up for review.

Yoav Farhi and others added 7 commits April 12, 2017 15:26
See https://en.[private link]%D8%B3%D9%86%DA%8C%D9%8A?replies=1#post-2586467

Merges r132527-wpcom.
The file now matche's core GP. Updating wpcom's locales is being tracked here:
https://[private link]

Merges r148109-wpcom.
jeherve and others added 12 commits April 12, 2017 15:35
When Photon is active, it resizes very large (`$too_big`) images to be 1200x1200px.
It also adjusts `og:image:width` and `og:image:height` to use these new values.
When Photon isn't active on the other hand, wp_get_attachment_image_src returns the original image. `og:image:width` and
`og:image:height` shouldn't be updated to 1200x1200.

Merges #3114 and #3116

Merges r131877-wpcom.
Fixes a typo in r131877, checking against correct `IS_WPCOM` constant (not `WPCOM`)

Should resolve cases where large images would result in open graph meta tags being output with incorrect dimensions.

See: r131877
See: https://[private link]

Merges r135069-wpcom.
… HTTPS to match WP.com sites and avoid mixed content errors.

Fixes #7745 props jeherve.

Merges r136338-wpcom.
…urn by wp_get_attachment_image_src.

This fixes the issue for new jetpack sync (4.2) where the publicised tweets were not including the featured image of a post in the tweet. Since in the new sync implementation we don't save the post meta information about the featured image  in the post meta. Now we sync data about the featured image and the attachment info as well.

Merges r139875-wpcom.
The `[gallery]` shortcode needs the global post object set to the context of
the shortcode so juggle the global object so we get the correct images back.

See:
https://[private link]#comment-24665

Merges r148733-wpcom.
Conflicts:
	class.jetpack-post-images.php
…cluded from a check in parse-logs

See: https://[private link]

Merges r119486-wpcom.
This was fixed in the Github Jetpack repo a year ago: 5ee6abd#diff-b7122d1b000681bcb6ca40926c711ab1

PHP 7 likes to complain about PHP 4 style constructors

Merges r138589-wpcom.
Summary:
Add a couple of bot/scraper user agents to is_bot_user_agent(), which is called in parse-logs.php.
Hide 'DOCUMENT_REFERRER' in stats, using users_hate_this_link().
See: https://[private link]

Test Plan:
[x] In wpsh, check that this returns TRUE: return Jetpack_User_Agent_Info::is_bot_user_agent( "Mozilla/5.0 (compatible; MSIE 10.0; Windows NT 6.1; Trident/6.0) LinkCheck by Siteimprove.com" )
[x] In wpsh, check that this returns TRUE: return Jetpack_User_Agent_Info::is_bot_user_agent( 'Mozilla/4.5 (compatible; HTTrack 3.0x; Windows 98)' )
[x] When sandboxed, check that no DOCUMENT_REFERRER referrer is listed here: https://wordpress.com/my-stats/?view=referrers&summarize&numdays=7&blog=2210655&unit=1

Reviewers: hypertextranch

Reviewed By: hypertextranch

Subscribers: batmoo

Differential Revision: https://[private link]

Merges r146608-wpcom.
Conflicts:
	class.jetpack-user-agent.php
Image extractor should return info about the gallery images got extracted from.

Merges r135012-wpcom.
@georgestephanis georgestephanis added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Apr 12, 2017
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this causes one of the Media Extractor tests to fail now.

Gallery being 0 now gets passed.  Confirmed that this is an intentional
change with @xyu.
@zinigor zinigor added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Apr 21, 2017
@georgestephanis georgestephanis merged commit c3a81a9 into master Apr 21, 2017
@georgestephanis georgestephanis deleted the wpcom/sync-misc-12april2017 branch April 21, 2017 17:15
@georgestephanis georgestephanis removed the [Status] Ready to Merge Go ahead, you can push that green button! label Apr 21, 2017
jeherve added a commit that referenced this pull request Apr 24, 2017
eliorivero pushed a commit that referenced this pull request Apr 25, 2017
* Changelog: initial commit for 4.9 release.

* Changelog: add #6929

* Changelog: move old changelogs to changelog.txt

* Readme: restore deleted release post link.

The post is now live.

* Changelog: add #6853

* Changelog: add #6856

* Changelog: add #6857

* Changelog: add #6884

* Changelog: add #6885

* Changelog: add #6892

* Changelog: add #6894

* Changelog: add #6898

* Changelog: add #6899

* Changelog: add #6900

* Changelog: add #6909

* Changelog: add #6927

* Changelog: add #6947

* Chagelog: add #6958

* Changelog: add #6961

* Changelog: add #6963

* Changelog: add #6965

* Changelog: add #6986

* Changelog: add #7000

* Changelog: add #7013

* Changelog: add #7015

* Changelog: add #7019

* Changelog: add #7028

* Changelog: add #6998

* Changelog: add #6999

* Changelog: add #7044

* Changelog: add #6881

* Changelog: add #6922

* Changelog: add #6940

* Changelog: add #6962

* Changelog: add #6942

* Changelog: add #6959

* Changelog: add #7018

* Changelog: add #6948

* Changelog: add #6657

* Changelog: add #7030

* Changelog: add #7048

* Changelog: add #7031

* Changelog: add #6990

* Changelog: add #6957

* Changelog: add #7027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants