Skip to content

Endpoints: make sure AtD file is loaded before AtD_get_options is used#7031

Merged
eliorivero merged 2 commits intomasterfrom
fix/load-atd-before-calling-function
Apr 25, 2017
Merged

Endpoints: make sure AtD file is loaded before AtD_get_options is used#7031
eliorivero merged 2 commits intomasterfrom
fix/load-atd-before-calling-function

Conversation

@eliorivero
Copy link
Copy Markdown
Contributor

@eliorivero eliorivero commented Apr 21, 2017 •
edited
Loading

Changes proposed in this Pull Request:

  • make sure AtD file is loaded before AtD_get_options is used
  • include files once and don't suppress warnings

To test:

  1. disable AtD
  2. go to Jetpack > Admin and run this in JS Console
jQuery.ajax( {
    url: 'https://thesite.tld/wp-json/jetpack/v4/settings',
    method: 'POST',
    beforeSend: function ( xhr ) {
        xhr.setRequestHeader( 'X-WP-Nonce', Initial_State.WP_API_nonce );
    },
    data: JSON.stringify( {
        'onpublish': true
    } ),
    contentType: "application/json",
    dataType: "json"
} ).done( function ( response ) {
    console.log( response );
} ).error( function ( error ) {
    console.log( error.responseText );
} );

It should succeed and not crash with an error like

br />
<b>Fatal error</b>:  Uncaught Error: Call to undefined function AtD_get_options() in /jetpack/_inc/lib/core-api/class.jetpack-core-api-module-endpoints.php:725

@eliorivero eliorivero added Admin Page React-powered dashboard under the Jetpack menu [Status] Needs Review This PR is ready for review. labels Apr 21, 2017
@eliorivero eliorivero self-assigned this Apr 21, 2017
@eliorivero eliorivero requested a review from dereksmart April 21, 2017 20:33
@jeherve jeherve added [Pri] Normal Bug When a feature is broken and / or not performing as intended labels Apr 23, 2017
dereksmart
dereksmart approved these changes Apr 25, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@dereksmart dereksmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑

@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Apr 25, 2017
@eliorivero eliorivero merged commit e3929f4 into master Apr 25, 2017
@eliorivero eliorivero deleted the fix/load-atd-before-calling-function branch April 25, 2017 00:07
@eliorivero eliorivero removed the [Status] Ready to Merge Go ahead, you can push that green button! label Apr 25, 2017
jeherve added a commit that referenced this pull request Apr 25, 2017
@jeherve
Changelog: add #7031
eb2ce10
eliorivero pushed a commit that referenced this pull request Apr 25, 2017
@jeherve @eliorivero
Changelog: 4.9 release. (#6949)
07307cb 
* Changelog: initial commit for 4.9 release.

* Changelog: add #6929

* Changelog: move old changelogs to changelog.txt

* Readme: restore deleted release post link.

The post is now live.

* Changelog: add #6853

* Changelog: add #6856

* Changelog: add #6857

* Changelog: add #6884

* Changelog: add #6885

* Changelog: add #6892

* Changelog: add #6894

* Changelog: add #6898

* Changelog: add #6899

* Changelog: add #6900

* Changelog: add #6909

* Changelog: add #6927

* Changelog: add #6947

* Chagelog: add #6958

* Changelog: add #6961

* Changelog: add #6963

* Changelog: add #6965

* Changelog: add #6986

* Changelog: add #7000

* Changelog: add #7013

* Changelog: add #7015

* Changelog: add #7019

* Changelog: add #7028

* Changelog: add #6998

* Changelog: add #6999

* Changelog: add #7044

* Changelog: add #6881

* Changelog: add #6922

* Changelog: add #6940

* Changelog: add #6962

* Changelog: add #6942

* Changelog: add #6959

* Changelog: add #7018

* Changelog: add #6948

* Changelog: add #6657

* Changelog: add #7030

* Changelog: add #7048

* Changelog: add #7031

* Changelog: add #6990

* Changelog: add #6957

* Changelog: add #7027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dereksmart dereksmart dereksmart approved these changes

Assignees

@eliorivero eliorivero

Labels

Admin Page React-powered dashboard under the Jetpack menu Bug When a feature is broken and / or not performing as intended [Pri] Normal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eliorivero @dereksmart @jeherve