Skip to content

Plugin compatibility: add Ninja Forms to the list of form plugins#6857

Merged
dereksmart merged 1 commit intomasterfrom
add/ninja-forms-conflicting
Apr 3, 2017
Merged

Plugin compatibility: add Ninja Forms to the list of form plugins#6857
dereksmart merged 1 commit intomasterfrom
add/ninja-forms-conflicting

Conversation

@jeherve
Copy link
Copy Markdown
Member

@jeherve jeherve commented Apr 3, 2017

Jetpack should not auto-activate its Contact Form module when Ninja Forms is active.

Proposed changelog entry for your changes:

  • Plugin Compatibility: do not auto-activate Jetpack's Contact Form module when Ninja Forms is active.

Jetpack should not auto-activate its Contact Form module when Ninja Forms is active.
@jeherve jeherve added [Feature] Forms [Pri] Normal [Status] Needs Review This PR is ready for review. Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Apr 3, 2017
@jeherve jeherve self-assigned this Apr 3, 2017
Copy link
Copy Markdown
Contributor

@dereksmart dereksmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough 👍

@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Apr 3, 2017
@dereksmart dereksmart merged commit 91580cd into master Apr 3, 2017
@dereksmart dereksmart removed the [Status] Ready to Merge Go ahead, you can push that green button! label Apr 3, 2017
@dereksmart dereksmart deleted the add/ninja-forms-conflicting branch April 3, 2017 14:32
jeherve added a commit that referenced this pull request Apr 24, 2017
eliorivero pushed a commit that referenced this pull request Apr 25, 2017
* Changelog: initial commit for 4.9 release.

* Changelog: add #6929

* Changelog: move old changelogs to changelog.txt

* Readme: restore deleted release post link.

The post is now live.

* Changelog: add #6853

* Changelog: add #6856

* Changelog: add #6857

* Changelog: add #6884

* Changelog: add #6885

* Changelog: add #6892

* Changelog: add #6894

* Changelog: add #6898

* Changelog: add #6899

* Changelog: add #6900

* Changelog: add #6909

* Changelog: add #6927

* Changelog: add #6947

* Chagelog: add #6958

* Changelog: add #6961

* Changelog: add #6963

* Changelog: add #6965

* Changelog: add #6986

* Changelog: add #7000

* Changelog: add #7013

* Changelog: add #7015

* Changelog: add #7019

* Changelog: add #7028

* Changelog: add #6998

* Changelog: add #6999

* Changelog: add #7044

* Changelog: add #6881

* Changelog: add #6922

* Changelog: add #6940

* Changelog: add #6962

* Changelog: add #6942

* Changelog: add #6959

* Changelog: add #7018

* Changelog: add #6948

* Changelog: add #6657

* Changelog: add #7030

* Changelog: add #7048

* Changelog: add #7031

* Changelog: add #6990

* Changelog: add #6957

* Changelog: add #7027
@oskosk
Copy link
Copy Markdown
Contributor

oskosk commented Oct 9, 2022

We need to revisit this decision and similar ones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Forms [Pri] Normal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants