Skip to content

Update/post by email input field#6894

Merged
jeherve merged 2 commits intomasterfrom
update/post-by-email-input-field
Apr 19, 2017
Merged

Update/post by email input field#6894
jeherve merged 2 commits intomasterfrom
update/post-by-email-input-field

Conversation

@eliorivero
Copy link
Copy Markdown
Contributor

Fixes #6835

Changes proposed in this Pull Request:

Before

captura de pantalla 2017-04-04 a las 12 37 06

After

captura de pantalla 2017-04-04 a las 12 37 23

Testing instructions:

  • Clear the Post by Email address and check that in the UI the field is empty and the label says "Create address"

…all to ensure a string is passed to regular expression
…d 'Create address' instead of 'Regenerate address'. Fix issue when address was deleted and was showing a '1' in the input field.
@eliorivero eliorivero added Admin Page React-powered dashboard under the Jetpack menu [Status] Needs Review This PR is ready for review. Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Apr 4, 2017
@eliorivero eliorivero added this to the Settings UI milestone Apr 4, 2017
@eliorivero eliorivero self-assigned this Apr 4, 2017
@eliorivero eliorivero requested review from dereksmart and jeherve April 4, 2017 15:39
@eliorivero eliorivero modified the milestones: 4.8.1, Settings UI Apr 5, 2017
@jeherve jeherve modified the milestone: 4.8.1 Apr 6, 2017
Copy link
Copy Markdown
Contributor

@dereksmart dereksmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑

@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Apr 12, 2017
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works in my tests! Merging.

@jeherve jeherve merged commit 8bbbea7 into master Apr 19, 2017
@jeherve jeherve deleted the update/post-by-email-input-field branch April 19, 2017 22:51
@jeherve jeherve added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! [Status] Needs Changelog labels Apr 19, 2017
jeherve added a commit that referenced this pull request Apr 24, 2017
eliorivero pushed a commit that referenced this pull request Apr 25, 2017
* Changelog: initial commit for 4.9 release.

* Changelog: add #6929

* Changelog: move old changelogs to changelog.txt

* Readme: restore deleted release post link.

The post is now live.

* Changelog: add #6853

* Changelog: add #6856

* Changelog: add #6857

* Changelog: add #6884

* Changelog: add #6885

* Changelog: add #6892

* Changelog: add #6894

* Changelog: add #6898

* Changelog: add #6899

* Changelog: add #6900

* Changelog: add #6909

* Changelog: add #6927

* Changelog: add #6947

* Chagelog: add #6958

* Changelog: add #6961

* Changelog: add #6963

* Changelog: add #6965

* Changelog: add #6986

* Changelog: add #7000

* Changelog: add #7013

* Changelog: add #7015

* Changelog: add #7019

* Changelog: add #7028

* Changelog: add #6998

* Changelog: add #6999

* Changelog: add #7044

* Changelog: add #6881

* Changelog: add #6922

* Changelog: add #6940

* Changelog: add #6962

* Changelog: add #6942

* Changelog: add #6959

* Changelog: add #7018

* Changelog: add #6948

* Changelog: add #6657

* Changelog: add #7030

* Changelog: add #7048

* Changelog: add #7031

* Changelog: add #6990

* Changelog: add #6957

* Changelog: add #7027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Admin Page React-powered dashboard under the Jetpack menu Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Pri] High

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants