XMLRPC: remove activateManage method#6990
Conversation
Since Jetpack 4.4, the Manage Module is now activated by default. We no longer need an XMLRPC method for it.
sirreal
left a comment
There was a problem hiding this comment.
I checked out this branch on a sandbox site (reports 4.9-alpha).
- From
wordpress.com/jetpack/connect✅ - From site's Jetpack dashboard ✅
Are there other flows which should be tested?
jeherve
left a comment
There was a problem hiding this comment.
Although the Manage module is enabled by default on new sites, it can still be disabled on existing sites. Shouldn't we leave the option in there to support existing installations where Manage is not currently enabled?
I'm not sure. Can you elaborate on situations where you think it may be needed. |
What happens if you deactivate Manage on your site (via |
|
Ah, thanks for clarifying. In that case, we send folks back to wp-admin to activate, and I think we should continue to do that rather than use an XMLRPC method. Longer term we are looking to rely less on, if not fully deprecate XMLRPC methods. If need be, we can use WP API to turn on manage from calypso. |
|
That makes sense. It seems the method is still mentioned in one of our wpcom API endpoints on WordPress.com ( |
True, and we are going to nuke that too! |
zinigor
left a comment
There was a problem hiding this comment.
LGTM, but let's merge the Calypso counterpart first.
|
Calypso PR has been merged. Merging to Jetpack 🐑 |
* Changelog: initial commit for 4.9 release. * Changelog: add #6929 * Changelog: move old changelogs to changelog.txt * Readme: restore deleted release post link. The post is now live. * Changelog: add #6853 * Changelog: add #6856 * Changelog: add #6857 * Changelog: add #6884 * Changelog: add #6885 * Changelog: add #6892 * Changelog: add #6894 * Changelog: add #6898 * Changelog: add #6899 * Changelog: add #6900 * Changelog: add #6909 * Changelog: add #6927 * Changelog: add #6947 * Chagelog: add #6958 * Changelog: add #6961 * Changelog: add #6963 * Changelog: add #6965 * Changelog: add #6986 * Changelog: add #7000 * Changelog: add #7013 * Changelog: add #7015 * Changelog: add #7019 * Changelog: add #7028 * Changelog: add #6998 * Changelog: add #6999 * Changelog: add #7044 * Changelog: add #6881 * Changelog: add #6922 * Changelog: add #6940 * Changelog: add #6962 * Changelog: add #6942 * Changelog: add #6959 * Changelog: add #7018 * Changelog: add #6948 * Changelog: add #6657 * Changelog: add #7030 * Changelog: add #7048 * Changelog: add #7031 * Changelog: add #6990 * Changelog: add #6957 * Changelog: add #7027
Since Jetpack 4.4, the Manage Module is now activated by default. We no longer need an XMLRPC method for it.
To test:
Add this PR to one of you Jetpack sites.
Test the various Jetpack Connect flows, and ensure there are no regressions.
Proposed changelog entry for your changes:
Removing an no longer necessary XMLRPC method.