Jetpack Notices: fix ugly VaultPress notice#6963
Conversation
|
This looks great. Is this notice dismissable, should it be? I guess it's a pretty big deal and would be fine to be persistent. cc @annezazu |
|
Will this clean up the double errors or will this just clean up the Jetpack error or both? :) |
|
@annezazu By double errors, do you mean that there is a notice showing in both the VP admin and the Jetpack admin? If so, it's worth pointing out that VP shows this notice also on every other page of the wp-admin, so I think showing it in Jetpack is intentional. |
|
Ah ok, I think the intent described in #6960 is to use WordPress.com's styling as much as possible while we're in the Jetpack admin, but I'll let @rickybanister verify that one. |
|
Yes, ideally we deprecate any 'vaultpress' specific styling and go with all 'calypso' styled notices, even outside of the Jetpack dashboard if this will appear there. That will set us up nicely for the future. |
|
Sorry, there was some miscommunication here. We want two things to happen here:
|
These things will need to be handled by the VaultPress plugin itself, so we'll need to request this on their p2. |
* Changelog: initial commit for 4.9 release. * Changelog: add #6929 * Changelog: move old changelogs to changelog.txt * Readme: restore deleted release post link. The post is now live. * Changelog: add #6853 * Changelog: add #6856 * Changelog: add #6857 * Changelog: add #6884 * Changelog: add #6885 * Changelog: add #6892 * Changelog: add #6894 * Changelog: add #6898 * Changelog: add #6899 * Changelog: add #6900 * Changelog: add #6909 * Changelog: add #6927 * Changelog: add #6947 * Chagelog: add #6958 * Changelog: add #6961 * Changelog: add #6963 * Changelog: add #6965 * Changelog: add #6986 * Changelog: add #7000 * Changelog: add #7013 * Changelog: add #7015 * Changelog: add #7019 * Changelog: add #7028 * Changelog: add #6998 * Changelog: add #6999 * Changelog: add #7044 * Changelog: add #6881 * Changelog: add #6922 * Changelog: add #6940 * Changelog: add #6962 * Changelog: add #6942 * Changelog: add #6959 * Changelog: add #7018 * Changelog: add #6948 * Changelog: add #6657 * Changelog: add #7030 * Changelog: add #7048 * Changelog: add #7031 * Changelog: add #6990 * Changelog: add #6957 * Changelog: add #7027


Fixes #6960
Manually remove the link to the VaultPress, so there's not two links anymore.
No more action notices.
Added an icon.
Before:

After:
