Skip to content

Settings UI: fix positioning of search icon on mobile screen size#6940

Merged
zinigor merged 1 commit intomasterfrom
fix/search-icon-positioning-small-screen
Apr 24, 2017
Merged

Settings UI: fix positioning of search icon on mobile screen size#6940
zinigor merged 1 commit intomasterfrom
fix/search-icon-positioning-small-screen

Conversation

@eliorivero
Copy link
Copy Markdown
Contributor

@eliorivero eliorivero commented Apr 6, 2017

Fixes #6917

Changes proposed in this Pull Request:

Before

captura de pantalla 2017-04-06 a las 15 12 44

After

captura de pantalla 2017-04-06 a las 15 12 31

Testing

Make sure the viewport size is < 480px and check that the icon is correctly positioned.

@eliorivero eliorivero added Admin Page React-powered dashboard under the Jetpack menu [Status] Needs Review This PR is ready for review. Bug When a feature is broken and / or not performing as intended labels Apr 6, 2017
@eliorivero eliorivero added this to the 4.8.2 milestone Apr 6, 2017
@eliorivero eliorivero self-assigned this Apr 6, 2017
@jeherve jeherve removed this from the 4.8.2 milestone Apr 7, 2017
Copy link
Copy Markdown
Contributor

@dereksmart dereksmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Apr 12, 2017
@jeherve jeherve modified the milestone: 4.9 Apr 24, 2017
@zinigor
Copy link
Copy Markdown
Contributor

zinigor commented Apr 24, 2017

Tested, works great!

@zinigor zinigor merged commit afc3091 into master Apr 24, 2017
@zinigor zinigor deleted the fix/search-icon-positioning-small-screen branch April 24, 2017 18:21
@zinigor zinigor removed the [Status] Ready to Merge Go ahead, you can push that green button! label Apr 24, 2017
jeherve added a commit that referenced this pull request Apr 24, 2017
eliorivero pushed a commit that referenced this pull request Apr 25, 2017
* Changelog: initial commit for 4.9 release.

* Changelog: add #6929

* Changelog: move old changelogs to changelog.txt

* Readme: restore deleted release post link.

The post is now live.

* Changelog: add #6853

* Changelog: add #6856

* Changelog: add #6857

* Changelog: add #6884

* Changelog: add #6885

* Changelog: add #6892

* Changelog: add #6894

* Changelog: add #6898

* Changelog: add #6899

* Changelog: add #6900

* Changelog: add #6909

* Changelog: add #6927

* Changelog: add #6947

* Chagelog: add #6958

* Changelog: add #6961

* Changelog: add #6963

* Changelog: add #6965

* Changelog: add #6986

* Changelog: add #7000

* Changelog: add #7013

* Changelog: add #7015

* Changelog: add #7019

* Changelog: add #7028

* Changelog: add #6998

* Changelog: add #6999

* Changelog: add #7044

* Changelog: add #6881

* Changelog: add #6922

* Changelog: add #6940

* Changelog: add #6962

* Changelog: add #6942

* Changelog: add #6959

* Changelog: add #7018

* Changelog: add #6948

* Changelog: add #6657

* Changelog: add #7030

* Changelog: add #7048

* Changelog: add #7031

* Changelog: add #6990

* Changelog: add #6957

* Changelog: add #7027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Admin Page React-powered dashboard under the Jetpack menu Bug When a feature is broken and / or not performing as intended [Pri] High

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants