Skip to content

Debugger: diplay the module list in Dev mode as well.#6959

Merged
eliorivero merged 2 commits intomasterfrom
update/module-list-dev
Apr 24, 2017
Merged

Debugger: diplay the module list in Dev mode as well.#6959
eliorivero merged 2 commits intomasterfrom
update/module-list-dev

Conversation

@jeherve
Copy link
Copy Markdown
Member

@jeherve jeherve commented Apr 10, 2017

Follow-up of #6770

Until now, the link to the full module list was only appearing when your site was connected to a WordPress.com account. That's not ideal when you're working with Jetpack locally.

Suggested here:
https://wordpress.org/support/topic/give-access-to-modules-list-on-the-dashboard/

@jeherve jeherve added [Feature] Offline Mode aka Development Mode or Debug Mode General [Pri] Normal [Status] Needs Review This PR is ready for review. Bug When a feature is broken and / or not performing as intended labels Apr 10, 2017
@jeherve jeherve self-assigned this Apr 10, 2017
<?php else : ?>
<?php elseif (
current_user_can( 'jetpack_manage_modules' )
&& Jetpack::is_development_mode()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But won't this now only display if it's in dev mode?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! Fixed in e5b41b4

@jeherve jeherve added this to the 4.9 milestone Apr 24, 2017
Copy link
Copy Markdown
Contributor

@dereksmart dereksmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Apr 24, 2017
@eliorivero
Copy link
Copy Markdown
Contributor

Works fine!

@eliorivero eliorivero merged commit ae0ebc7 into master Apr 24, 2017
@eliorivero eliorivero deleted the update/module-list-dev branch April 24, 2017 22:26
@eliorivero eliorivero removed the [Status] Ready to Merge Go ahead, you can push that green button! label Apr 24, 2017
jeherve added a commit that referenced this pull request Apr 24, 2017
eliorivero pushed a commit that referenced this pull request Apr 25, 2017
* Changelog: initial commit for 4.9 release.

* Changelog: add #6929

* Changelog: move old changelogs to changelog.txt

* Readme: restore deleted release post link.

The post is now live.

* Changelog: add #6853

* Changelog: add #6856

* Changelog: add #6857

* Changelog: add #6884

* Changelog: add #6885

* Changelog: add #6892

* Changelog: add #6894

* Changelog: add #6898

* Changelog: add #6899

* Changelog: add #6900

* Changelog: add #6909

* Changelog: add #6927

* Changelog: add #6947

* Chagelog: add #6958

* Changelog: add #6961

* Changelog: add #6963

* Changelog: add #6965

* Changelog: add #6986

* Changelog: add #7000

* Changelog: add #7013

* Changelog: add #7015

* Changelog: add #7019

* Changelog: add #7028

* Changelog: add #6998

* Changelog: add #6999

* Changelog: add #7044

* Changelog: add #6881

* Changelog: add #6922

* Changelog: add #6940

* Changelog: add #6962

* Changelog: add #6942

* Changelog: add #6959

* Changelog: add #7018

* Changelog: add #6948

* Changelog: add #6657

* Changelog: add #7030

* Changelog: add #7048

* Changelog: add #7031

* Changelog: add #6990

* Changelog: add #6957

* Changelog: add #7027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug When a feature is broken and / or not performing as intended [Feature] Offline Mode aka Development Mode or Debug Mode General [Pri] Normal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants