Skip to content

Add a Jetpack Sync action for theme installation#7013

Merged
gititon merged 8 commits intomasterfrom
add/sync_theme
Apr 20, 2017
Merged

Add a Jetpack Sync action for theme installation#7013
gititon merged 8 commits intomasterfrom
add/sync_theme

Conversation

@gititon
Copy link
Copy Markdown
Contributor

@gititon gititon commented Apr 20, 2017

Adds a Jetpack Sync action for theme installation

Changes proposed in this Pull Request:

Adds a Jetpack Sync action for theme installation via the addition of jetpack_installed_theme action

Testing instructions:

phpunit to run new test for theme install sync

Proposed changelog entry for your changes:

jetpack_installed_theme action added upon theme installation

@gititon gititon added [Package] Sync [Pri] Normal [Status] Needs Review This PR is ready for review. [Status] Ready to Merge Go ahead, you can push that green button! [Team] Poseidon labels Apr 20, 2017
@gititon gititon requested review from enejb and lezama April 20, 2017 18:53
@lezama
Copy link
Copy Markdown
Contributor

lezama commented Apr 20, 2017

Great!

Copy link
Copy Markdown
Contributor

@lezama lezama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@lezama lezama removed the [Status] Ready to Merge Go ahead, you can push that green button! label Apr 20, 2017
}

//$upgrader = new Theme_Upgrader( new Theme_Upgrader_Skin( compact('title', 'nonce', 'url', 'theme') ) );

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets remove comment or the space.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@enejb
Copy link
Copy Markdown
Member

enejb commented Apr 20, 2017

Looks great!

Copy link
Copy Markdown
Member

@enejb enejb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

@gititon gititon merged commit 6ccf44e into master Apr 20, 2017
@gititon gititon deleted the add/sync_theme branch April 20, 2017 20:47
@matticbot matticbot removed the [Status] Needs Review This PR is ready for review. label Apr 20, 2017
jeherve added a commit that referenced this pull request Apr 24, 2017
eliorivero pushed a commit that referenced this pull request Apr 25, 2017
* Changelog: initial commit for 4.9 release.

* Changelog: add #6929

* Changelog: move old changelogs to changelog.txt

* Readme: restore deleted release post link.

The post is now live.

* Changelog: add #6853

* Changelog: add #6856

* Changelog: add #6857

* Changelog: add #6884

* Changelog: add #6885

* Changelog: add #6892

* Changelog: add #6894

* Changelog: add #6898

* Changelog: add #6899

* Changelog: add #6900

* Changelog: add #6909

* Changelog: add #6927

* Changelog: add #6947

* Chagelog: add #6958

* Changelog: add #6961

* Changelog: add #6963

* Changelog: add #6965

* Changelog: add #6986

* Changelog: add #7000

* Changelog: add #7013

* Changelog: add #7015

* Changelog: add #7019

* Changelog: add #7028

* Changelog: add #6998

* Changelog: add #6999

* Changelog: add #7044

* Changelog: add #6881

* Changelog: add #6922

* Changelog: add #6940

* Changelog: add #6962

* Changelog: add #6942

* Changelog: add #6959

* Changelog: add #7018

* Changelog: add #6948

* Changelog: add #6657

* Changelog: add #7030

* Changelog: add #7048

* Changelog: add #7031

* Changelog: add #6990

* Changelog: add #6957

* Changelog: add #7027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants