Skip to content

Sync: Separate User Events: Add, Register and Update user events should be different#7000

Merged
lezama merged 3 commits intomasterfrom
add/sync-add-user-event
Apr 20, 2017
Merged

Sync: Separate User Events: Add, Register and Update user events should be different#7000
lezama merged 3 commits intomasterfrom
add/sync-add-user-event

Conversation

@enejb
Copy link
Copy Markdown
Member

@enejb enejb commented Apr 19, 2017

This will help us know what event took place on the .com side. Instead of just updating the

Changes proposed in this Pull Request:

  • Separate the 3 events into separate actions. Add, Register and Update user.

Testing instructions:

  • Do the tests pass?
    Do the Multi Site tests pass?
    phpunit -c tests/php.multisite.xml --filter=user

Proposed changelog entry for your changes:

Seperate the Sync user events. Into more meaningful events.

@enejb enejb added [Package] Sync [Status] Needs Review This PR is ready for review. labels Apr 19, 2017
@enejb enejb self-assigned this Apr 19, 2017
@enejb enejb requested review from gititon and lezama April 19, 2017 20:18
Copy link
Copy Markdown
Contributor

@lezama lezama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@lezama lezama merged commit d432278 into master Apr 20, 2017
@lezama lezama deleted the add/sync-add-user-event branch April 20, 2017 17:16
@matticbot matticbot removed the [Status] Needs Review This PR is ready for review. label Apr 20, 2017
jeherve added a commit that referenced this pull request Apr 24, 2017
eliorivero pushed a commit that referenced this pull request Apr 25, 2017
* Changelog: initial commit for 4.9 release.

* Changelog: add #6929

* Changelog: move old changelogs to changelog.txt

* Readme: restore deleted release post link.

The post is now live.

* Changelog: add #6853

* Changelog: add #6856

* Changelog: add #6857

* Changelog: add #6884

* Changelog: add #6885

* Changelog: add #6892

* Changelog: add #6894

* Changelog: add #6898

* Changelog: add #6899

* Changelog: add #6900

* Changelog: add #6909

* Changelog: add #6927

* Changelog: add #6947

* Chagelog: add #6958

* Changelog: add #6961

* Changelog: add #6963

* Changelog: add #6965

* Changelog: add #6986

* Changelog: add #7000

* Changelog: add #7013

* Changelog: add #7015

* Changelog: add #7019

* Changelog: add #7028

* Changelog: add #6998

* Changelog: add #6999

* Changelog: add #7044

* Changelog: add #6881

* Changelog: add #6922

* Changelog: add #6940

* Changelog: add #6962

* Changelog: add #6942

* Changelog: add #6959

* Changelog: add #7018

* Changelog: add #6948

* Changelog: add #6657

* Changelog: add #7030

* Changelog: add #7048

* Changelog: add #7031

* Changelog: add #6990

* Changelog: add #6957

* Changelog: add #7027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants