Skip to content

Stats: Make sure get_editable_roles exists before to use it.#6957

Merged
eliorivero merged 1 commit intomasterfrom
fix/missing-roles-6645
Apr 25, 2017
Merged

Stats: Make sure get_editable_roles exists before to use it.#6957
eliorivero merged 1 commit intomasterfrom
fix/missing-roles-6645

Conversation

@jeherve
Copy link
Copy Markdown
Member

@jeherve jeherve commented Apr 10, 2017

Fixes #6645

Proposed changelog entry for your changes:

  • Stats: avoid PHP warnings and errors in the Stats dashboard on Multisite.

@jeherve jeherve added Admin Page React-powered dashboard under the Jetpack menu [Feature] Stats Data Feature that enables users to track their site's traffic and gain insights on popular content. [Pri] Normal [Status] Needs Review This PR is ready for review. Bug When a feature is broken and / or not performing as intended labels Apr 10, 2017
@jeherve jeherve self-assigned this Apr 10, 2017
Copy link
Copy Markdown
Contributor

@dereksmart dereksmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Apr 12, 2017
@eliorivero
Copy link
Copy Markdown
Contributor

Nice, merging.

@eliorivero eliorivero merged commit bb9a2f5 into master Apr 25, 2017
@eliorivero eliorivero deleted the fix/missing-roles-6645 branch April 25, 2017 00:13
@eliorivero eliorivero removed the [Status] Ready to Merge Go ahead, you can push that green button! label Apr 25, 2017
jeherve added a commit that referenced this pull request Apr 25, 2017
eliorivero pushed a commit that referenced this pull request Apr 25, 2017
* Changelog: initial commit for 4.9 release.

* Changelog: add #6929

* Changelog: move old changelogs to changelog.txt

* Readme: restore deleted release post link.

The post is now live.

* Changelog: add #6853

* Changelog: add #6856

* Changelog: add #6857

* Changelog: add #6884

* Changelog: add #6885

* Changelog: add #6892

* Changelog: add #6894

* Changelog: add #6898

* Changelog: add #6899

* Changelog: add #6900

* Changelog: add #6909

* Changelog: add #6927

* Changelog: add #6947

* Chagelog: add #6958

* Changelog: add #6961

* Changelog: add #6963

* Changelog: add #6965

* Changelog: add #6986

* Changelog: add #7000

* Changelog: add #7013

* Changelog: add #7015

* Changelog: add #7019

* Changelog: add #7028

* Changelog: add #6998

* Changelog: add #6999

* Changelog: add #7044

* Changelog: add #6881

* Changelog: add #6922

* Changelog: add #6940

* Changelog: add #6962

* Changelog: add #6942

* Changelog: add #6959

* Changelog: add #7018

* Changelog: add #6948

* Changelog: add #6657

* Changelog: add #7030

* Changelog: add #7048

* Changelog: add #7031

* Changelog: add #6990

* Changelog: add #6957

* Changelog: add #7027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Admin Page React-powered dashboard under the Jetpack menu Bug When a feature is broken and / or not performing as intended [Feature] Stats Data Feature that enables users to track their site's traffic and gain insights on popular content. [Pri] Normal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants