Skip to content

Uninstall: Fix fatal due to sync listeners being added for the delete_plugin action#6947

Merged
enejb merged 1 commit intomasterfrom
fix/6938-fatal-on-unistall
Apr 7, 2017
Merged

Uninstall: Fix fatal due to sync listeners being added for the delete_plugin action#6947
enejb merged 1 commit intomasterfrom
fix/6938-fatal-on-unistall

Conversation

@enejb
Copy link
Copy Markdown
Member

@enejb enejb commented Apr 7, 2017

Fixes #6938

Changes proposed in this Pull Request:

  • Do not load any modules and listeners when initialising the sender.

Testing instructions:

  • Load branch. Delete plugin notice that there are no fatal error.

@enejb enejb requested review from dereksmart and lezama April 7, 2017 17:37
Copy link
Copy Markdown
Contributor

@dereksmart dereksmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed fixes it!

@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! Bug When a feature is broken and / or not performing as intended and removed [Status] Needs Review This PR is ready for review. labels Apr 7, 2017
@enejb enejb merged commit 12d3014 into master Apr 7, 2017
@enejb enejb deleted the fix/6938-fatal-on-unistall branch April 7, 2017 20:07
@matticbot matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Apr 7, 2017
jeherve added a commit that referenced this pull request Apr 24, 2017
eliorivero pushed a commit that referenced this pull request Apr 25, 2017
* Changelog: initial commit for 4.9 release.

* Changelog: add #6929

* Changelog: move old changelogs to changelog.txt

* Readme: restore deleted release post link.

The post is now live.

* Changelog: add #6853

* Changelog: add #6856

* Changelog: add #6857

* Changelog: add #6884

* Changelog: add #6885

* Changelog: add #6892

* Changelog: add #6894

* Changelog: add #6898

* Changelog: add #6899

* Changelog: add #6900

* Changelog: add #6909

* Changelog: add #6927

* Changelog: add #6947

* Chagelog: add #6958

* Changelog: add #6961

* Changelog: add #6963

* Changelog: add #6965

* Changelog: add #6986

* Changelog: add #7000

* Changelog: add #7013

* Changelog: add #7015

* Changelog: add #7019

* Changelog: add #7028

* Changelog: add #6998

* Changelog: add #6999

* Changelog: add #7044

* Changelog: add #6881

* Changelog: add #6922

* Changelog: add #6940

* Changelog: add #6962

* Changelog: add #6942

* Changelog: add #6959

* Changelog: add #7018

* Changelog: add #6948

* Changelog: add #6657

* Changelog: add #7030

* Changelog: add #7048

* Changelog: add #7031

* Changelog: add #6990

* Changelog: add #6957

* Changelog: add #7027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug When a feature is broken and / or not performing as intended General [Package] Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants