Skip to content

Autoupdates: Remove plugin autoupdates from the Jetpack side of things#7015

Merged
enejb merged 1 commit intomasterfrom
remove/remove-jetpack-autoupdate-plugins
Apr 21, 2017
Merged

Autoupdates: Remove plugin autoupdates from the Jetpack side of things#7015
enejb merged 1 commit intomasterfrom
remove/remove-jetpack-autoupdate-plugins

Conversation

@enejb
Copy link
Copy Markdown
Member

@enejb enejb commented Apr 20, 2017

Since we are fireing the autoupdated events from .com. Lets only do autoupdates from there.
This has a number of benefits.

  • We can stop autoupdates from happening if we know that a site will brake due to an autoupdated.
  • Have better events when the autoupdate does happen.

Testing instructions:

  • Test that the autoupdate doesn't happen for plugins again more.

@enejb enejb added [Feature] Manage [Status] Needs Review This PR is ready for review. [Status] Needs Testing We need to add this change to the testing call for this month's release labels Apr 20, 2017
@enejb enejb requested review from lezama and roccotripaldi April 20, 2017 19:05
Copy link
Copy Markdown
Contributor

@lezama lezama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Copy Markdown
Contributor

@roccotripaldi roccotripaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can remove the entire file class.jetpack-autoupdate.php - but LGTM!

}

if ( ! empty( $this->failed['plugin'] ) ) {
$instance->stat( 'autoupdates/plugin-fail', count( $this->failed['plugin'] ) );
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we still keeping this stat on WPCOM side?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we have seperate stats on the .com side for the new autoupdating.

@enejb
Copy link
Copy Markdown
Member Author

enejb commented Apr 21, 2017

Maybe we can remove the entire file class.jetpack-autoupdate.php - but LGTM! Yes we should do that. But lets make it happen first for the Plugins.

@enejb enejb merged commit dd0c6a6 into master Apr 21, 2017
@enejb enejb deleted the remove/remove-jetpack-autoupdate-plugins branch April 21, 2017 22:02
@matticbot matticbot removed the [Status] Needs Review This PR is ready for review. label Apr 21, 2017
jeherve added a commit that referenced this pull request Apr 24, 2017
eliorivero pushed a commit that referenced this pull request Apr 25, 2017
* Changelog: initial commit for 4.9 release.

* Changelog: add #6929

* Changelog: move old changelogs to changelog.txt

* Readme: restore deleted release post link.

The post is now live.

* Changelog: add #6853

* Changelog: add #6856

* Changelog: add #6857

* Changelog: add #6884

* Changelog: add #6885

* Changelog: add #6892

* Changelog: add #6894

* Changelog: add #6898

* Changelog: add #6899

* Changelog: add #6900

* Changelog: add #6909

* Changelog: add #6927

* Changelog: add #6947

* Chagelog: add #6958

* Changelog: add #6961

* Changelog: add #6963

* Changelog: add #6965

* Changelog: add #6986

* Changelog: add #7000

* Changelog: add #7013

* Changelog: add #7015

* Changelog: add #7019

* Changelog: add #7028

* Changelog: add #6998

* Changelog: add #6999

* Changelog: add #7044

* Changelog: add #6881

* Changelog: add #6922

* Changelog: add #6940

* Changelog: add #6962

* Changelog: add #6942

* Changelog: add #6959

* Changelog: add #7018

* Changelog: add #6948

* Changelog: add #6657

* Changelog: add #7030

* Changelog: add #7048

* Changelog: add #7031

* Changelog: add #6990

* Changelog: add #6957

* Changelog: add #7027
@jeherve jeherve removed the [Status] Needs Testing We need to add this change to the testing call for this month's release label May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants