Conversation
This PR lets us sync changes as they happen to the sidebar.
lezama
reviewed
Apr 5, 2017
| add_action( 'jetpack_sync_current_theme_support', $callable ); | ||
|
|
||
| // Sidebar updates. | ||
| add_action( "update_option_sidebars_widgets", array( $this, 'sync_sidebar_widgets_actions' ), 10, 2 ); |
Contributor
There was a problem hiding this comment.
this could use single quotes
lezama
reviewed
Apr 5, 2017
| foreach( $added_widgets as $added_widget ) { | ||
| $moved_to_sidebar[] = $added_widget; | ||
| /** | ||
| * Helps Sync log that a widget got add |
lezama
reviewed
Apr 5, 2017
| // lets check if we didn't move the widget to in_active_widgets | ||
|
|
||
| if ( isset( $new_value['wp_inactive_widgets'] ) && ! in_array( $removed_widget, $new_value['wp_inactive_widgets'] ) ) { | ||
| echo "remove...."; |
Contributor
|
there are some minor coding standards issues that we should fix before merging |
thingalon
approved these changes
Apr 6, 2017
Member
thingalon
left a comment
There was a problem hiding this comment.
Success; I see the new events rolling through when I force my wpcom sandbox to dump Jetpack Sync events: :-)
gititon
reviewed
Apr 6, 2017
| return array( $this->get_theme_support_info() ); | ||
| } | ||
|
|
||
| function sync_sidebar_widgets_actions( $old_value, $new_value ) { |
Contributor
There was a problem hiding this comment.
This isn't a blocking comment, but the sync_sidebar_widgets_actions() method is handling a number of widget action types. Consider handling each in a small method of its own that is called from sync_sidebar_widgets_actions().
gititon
reviewed
Apr 6, 2017
| $this->assertEquals( $local_value, $this->server_replica_storage->get_option( 'theme_mods_' . $this->theme ) ); | ||
| } | ||
|
|
||
| public function test_widgets_changes_get_synced() { |
Contributor
There was a problem hiding this comment.
This isn't a blocking comment, but consider different tests for the different widget sync event types.
eliorivero
pushed a commit
that referenced
this pull request
Apr 25, 2017
* Changelog: initial commit for 4.9 release. * Changelog: add #6929 * Changelog: move old changelogs to changelog.txt * Readme: restore deleted release post link. The post is now live. * Changelog: add #6853 * Changelog: add #6856 * Changelog: add #6857 * Changelog: add #6884 * Changelog: add #6885 * Changelog: add #6892 * Changelog: add #6894 * Changelog: add #6898 * Changelog: add #6899 * Changelog: add #6900 * Changelog: add #6909 * Changelog: add #6927 * Changelog: add #6947 * Chagelog: add #6958 * Changelog: add #6961 * Changelog: add #6963 * Changelog: add #6965 * Changelog: add #6986 * Changelog: add #7000 * Changelog: add #7013 * Changelog: add #7015 * Changelog: add #7019 * Changelog: add #7028 * Changelog: add #6998 * Changelog: add #6999 * Changelog: add #7044 * Changelog: add #6881 * Changelog: add #6922 * Changelog: add #6940 * Changelog: add #6962 * Changelog: add #6942 * Changelog: add #6959 * Changelog: add #7018 * Changelog: add #6948 * Changelog: add #6657 * Changelog: add #7030 * Changelog: add #7048 * Changelog: add #7031 * Changelog: add #6990 * Changelog: add #6957 * Changelog: add #7027
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lets us sync changes as they happen to the sidebar.
Currently we don't have enough info that will let us see what is happening to the sidebar.
Changes proposed in this Pull Request:
Testing instructions: