Related Posts: Fix fatal when the exclusion parameter is not a string#6922
Merged
zinigor merged 1 commit intoAutomattic:masterfrom Apr 24, 2017
Merged
Conversation
Some requests for related posts are using a malformed URL where the `relatedposts_exclude` parameter is of type array, not of type string, causing `explode()` to fatal. This change checks the type of the `relatedpost_exclude` parameter, and will perform the original `explode()` if it is a string; or extract the values if it's an array. We sanitize the values to ensure they are valid ints for use as `$excludes`. Props @jmdodd
Member
Author
|
Changes have already been deployed to WPCOM side. |
dereksmart
approved these changes
Apr 5, 2017
Contributor
|
Travis is failing because it can't use |
eliorivero
pushed a commit
that referenced
this pull request
Apr 25, 2017
* Changelog: initial commit for 4.9 release. * Changelog: add #6929 * Changelog: move old changelogs to changelog.txt * Readme: restore deleted release post link. The post is now live. * Changelog: add #6853 * Changelog: add #6856 * Changelog: add #6857 * Changelog: add #6884 * Changelog: add #6885 * Changelog: add #6892 * Changelog: add #6894 * Changelog: add #6898 * Changelog: add #6899 * Changelog: add #6900 * Changelog: add #6909 * Changelog: add #6927 * Changelog: add #6947 * Chagelog: add #6958 * Changelog: add #6961 * Changelog: add #6963 * Changelog: add #6965 * Changelog: add #6986 * Changelog: add #7000 * Changelog: add #7013 * Changelog: add #7015 * Changelog: add #7019 * Changelog: add #7028 * Changelog: add #6998 * Changelog: add #6999 * Changelog: add #7044 * Changelog: add #6881 * Changelog: add #6922 * Changelog: add #6940 * Changelog: add #6962 * Changelog: add #6942 * Changelog: add #6959 * Changelog: add #7018 * Changelog: add #6948 * Changelog: add #6657 * Changelog: add #7030 * Changelog: add #7048 * Changelog: add #7031 * Changelog: add #6990 * Changelog: add #6957 * Changelog: add #7027
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some requests for related posts are using a malformed URL where the
relatedposts_excludeparameter is of type array, not of type string, causingexplode()to fatal.This change checks the type of the
relatedpost_excludeparameter, and willperform the original
explode()if it is a string; or extract the values ifit's an array. We sanitize the values to ensure they are valid ints for use as
$excludes.Props @jmdodd
Fixes #N/A
Changes proposed in this Pull Request:
Testing instructions:
relatedposts_exclude[]=Xandrelatedposts_exclude=Xboth exclude post_id X.