Sync: Adda a way to distinguish between an added and an updated attachment#6884
Merged
Sync: Adda a way to distinguish between an added and an updated attachment#6884
Conversation
lezama
reviewed
Apr 3, 2017
| */ | ||
| do_action( 'jetpack_sync_save_add_attachment', $attachment_id, $attachment ); | ||
| $filter = current_filter(); | ||
| do_action( 'jetpack_sync_save_add_attachment', $attachment_id, $attachment, $filter ); |
Contributor
There was a problem hiding this comment.
I think it would be more semantic and easier to search if we sync two different actions, what do you think?
Member
Author
There was a problem hiding this comment.
Yes that makes sense I have split up the actions and now we sync both of them.
jeherve
previously requested changes
Apr 4, 2017
| */ | ||
| do_action( 'jetpack_sync_save_add_attachment', $attachment_id, $attachment ); | ||
| $filter = current_filter(); | ||
| do_action( 'jetpack_sync_save_add_attachment', $attachment_id, $attachment, $filter ); |
Member
There was a problem hiding this comment.
Could you move the action one line up? The parser won't find the docblock if there is another line of code above it.
Member
Author
|
I split the event. This will also require a change on the .com side. Will do this after a consensus on this approach. Also will need to update the tests of the activity log. |
Contributor
|
I vote for this solution by a lot, let's fix the tests :) |
eliorivero
pushed a commit
that referenced
this pull request
Apr 25, 2017
* Changelog: initial commit for 4.9 release. * Changelog: add #6929 * Changelog: move old changelogs to changelog.txt * Readme: restore deleted release post link. The post is now live. * Changelog: add #6853 * Changelog: add #6856 * Changelog: add #6857 * Changelog: add #6884 * Changelog: add #6885 * Changelog: add #6892 * Changelog: add #6894 * Changelog: add #6898 * Changelog: add #6899 * Changelog: add #6900 * Changelog: add #6909 * Changelog: add #6927 * Changelog: add #6947 * Chagelog: add #6958 * Changelog: add #6961 * Changelog: add #6963 * Changelog: add #6965 * Changelog: add #6986 * Changelog: add #7000 * Changelog: add #7013 * Changelog: add #7015 * Changelog: add #7019 * Changelog: add #7028 * Changelog: add #6998 * Changelog: add #6999 * Changelog: add #7044 * Changelog: add #6881 * Changelog: add #6922 * Changelog: add #6940 * Changelog: add #6962 * Changelog: add #6942 * Changelog: add #6959 * Changelog: add #7018 * Changelog: add #6948 * Changelog: add #6657 * Changelog: add #7030 * Changelog: add #7048 * Changelog: add #7031 * Changelog: add #6990 * Changelog: add #6957 * Changelog: add #7027
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Current we can't tell if an user added or updated an attachment.
This PR tries so solve this by adding the current filter to the action being synced.
Testing instructions: