Post Images: always use real image dimensions in OG Tags#3114
Merged
dereksmart merged 1 commit intomasterfrom Dec 8, 2015
Merged
Post Images: always use real image dimensions in OG Tags#3114dereksmart merged 1 commit intomasterfrom
dereksmart merged 1 commit intomasterfrom
Conversation
When Photon is active, it resizes very large (`$too_big`) images to be 1200x1200px. It also adjusts `og:image:width` and `og:image:height` to use these new values. When Photon isn't active on the other hand, wp_get_attachment_image_src returns the original image. `og:image:width` and `og:image:height` shouldn't be updated to 1200x1200. Reported here: https://wordpress.org/support/topic/publicize-featured-image-problem-on-facebook
Member
Author
|
Related: 1bdffc8 |
dereksmart
added a commit
that referenced
this pull request
Dec 8, 2015
…g-no-photon Post Images: always use real image dimensions in OG Tags
jeherve
added a commit
that referenced
this pull request
Dec 9, 2015
Like on WordPress.com. Error introduced in #3114
georgestephanis
pushed a commit
that referenced
this pull request
Apr 12, 2017
When Photon is active, it resizes very large (`$too_big`) images to be 1200x1200px. It also adjusts `og:image:width` and `og:image:height` to use these new values. When Photon isn't active on the other hand, wp_get_attachment_image_src returns the original image. `og:image:width` and `og:image:height` shouldn't be updated to 1200x1200. Merges #3114 and #3116 Merges r131877-wpcom.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Photon is active, it resizes very large (
$too_big) images to be 1200x1200px. It also adjustsog:image:widthandog:image:heightto use these new values.When Photon isn't active on the other hand, wp_get_attachment_image_src returns the original image.
og:image:widthandog:image:heightshouldn't be updated to 1200x1200.Reported here:
https://wordpress.org/support/topic/publicize-featured-image-problem-on-facebook