Conversation
* Fix unescaped ampersand validation error * removed htmlspecialchar
…oomla#8951) * improve get two factor authentication in mod_login (site & admin) and offline template * uniformize spaces * use php 5.3 compatible syntax thanks again @mbabker * the same for frontend component user view login too * continue using onUserTwofactorIdentify trigger * cs - empty line at the end of file * fix conflicts 1 * fix conflicts 2 * fix conflicts final * __DEPLOY_VERSION__ * improve code blocks
* Admin status module updates * Added separator + removed class for multilingual status label * Moved separator element inside button group container * Removed tooltip * Fixed on RTL + removed whitespace * Removed old language strings for tooltip * Re-added tooltip language strings * order language strings alphabetically * Build generatecss.php
…new/edit tag view (joomla#11141) * Added tooltip of created date,created by and modified date fields at tag new/edit view * Modified created by description text and set language string in alpha order
* Change menu to link * Update print email options
…oomla#11263) * add language var * go back to original language var message in 3.6.2 * "not able" to "unable" * remove the bag
* blacklist * whitelist * remove vendor
* Capitalise labels * oops missed one * oops missed two * Email Language * use modifiers
* Remove colon from tooltip * Use tip instead of desc
* Correct and clarify tooltip in tag options * update
* Mail function disabled * replace the with an
* Simplify some language * merge conflicts * merge conflict
* update gitignore * oops missed one * Newsfeedoption float image * oops * oops
The $idField is never used throughout the code, seems to be an attempt to sanitize the id. I've added some more filtering to produce a usable id.
* Update composer libraries * Fix sample testing data json
* Simplify strings * oops * comma * caps * caps again
joomla#11528) * Fix for joomla#11521 : Isis admin menu on small viewport width devices Do not run auto-scrolling on small devices for Isis admin menu * Adjust min-width for auto-scrolling * Remove extra empty line
* fix the update cachtime description * language fix
…lighter.js library (joomla#11644) * highlighter.js test suite * Changed value in since tag to __DEPLOY_VERSION__
…cher.js library (joomla#11645) * switcher.js test suite * Removed a new line * Restructured code
* Fixed mistake after 11265 * Missing dot
Pull Request for Issue joomla#10901 the old PR joomla#10901 and joomla#10912 seems inadeguate :( Summary of Changes Set hide by default the parameter which have no effect until the first saving
* fix doc blocks * double spaces
* we need isset here to not have a php notice * Update item.php
…orm-repeatable.js library (joomla#11646) * subform-repeatable.js test suite * Updated docs section
* Update finder.xml * Update finder.xml
* toolbar * Revert "toolbar" This reverts commit 8f995f1. * tinymce code icon on toolbar
…in protostar offline template (joomla#11667)
…#11642) * Language filter alternate meta default is 1 * Update languagefilter.php * Update languagefilter.php
* Render all exceptions on error page when in debug mode * Displaying wrong error message * Small logic tweak so Exceptions aren't skipped * Stacked exceptions for all templates * Add language string
ggppdk
pushed a commit
that referenced
this pull request
Dec 21, 2016
… (joomla#12292) * Cleanups, fixes and a bit of optimizations for site/components batch #3 - com_content Note: This is a single commit bundling all types of changes, since PR joomla#12261 which had detailed commits, was rejected as a whole * Ch-Ch-Ch-Changes! Made some changes as pointed out by @andrepereiradasilva * A bit more... * Revert * Removed empty function, as there is a fallback. Change made according to comment from @wilsonge * Included @andrepereiradasilva's suggestions * Inserting whitespace before php closing tag
ggppdk
pushed a commit
that referenced
this pull request
Dec 26, 2016
* Replace unnecessary double quotes * And one unnecessary semicolon... ;) * CS Fix + removal of unnecessary space * some more double quote replacements * Changes, based on @shur's comments
Bakual
pushed a commit
that referenced
this pull request
Jan 14, 2017
* Some improvements in tests #3: - call static methods correctly * Fix T_PAAMAYIM_NEKUDOTAYIM (for all PHP 5.x) * Remove forgotten call * Changed a few things after conversation with @mbabker * Fixes according to @andrepereiradasilva's comments
ggppdk
pushed a commit
that referenced
this pull request
Dec 6, 2018
* This is a combination of 8 commits. This is the 1st commit message: > First WIP version of supporting nested subforms. This is the commit message #2: > Fix nested subforms not getting correct name attribute on input fields. This is the commit message #3: > Fix subform rows having invalid index, fix small typo. This is the commit message #4: > Replace the unique subform id via random bytes by just an increasing integer in the fields type rendering process. This is the commit message #5: > Implement feedback from PR at Joomla; > - Use a <template> HTML element for the template of the subform rows, > not a url encoded string inside of a <script> element. > - Fix code style errors reported by phpcs. > - Make the fixing of the unique attributes (name, id, etc) of input elements > of nested subform rows more errorprone, using the same method as the main > subform row. > - Manually add a minified version of the javascript file. This is the commit message #6: > Fix failing javascript tests due to changed structure of subform repeatable template container. This is the commit message joomla#7: > Change subform repeatable javascript test to correctly check on > 0-indexed rows, previously they have been 1-indexed. This is the commit message joomla#8: > Fix a problem where multi-level subforms on the same level doesnt trigger their template correctly. > Additionally added a note why the fixScripts() method is broken and how it could get better. * Commit code styling errors and add an aria label for the outermost 'add' button. * Fix double group-add button on repeatable subform type.
laoneo
pushed a commit
that referenced
this pull request
Mar 24, 2022
…t of type int (joomla#36775) Fixes `Deprecated: preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated in libraries/src/Document/HtmlDocument.php on line 595`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Documentation Changes Required