NOTE: The travis errors are unrelated to this PR

@klas Can you update your PR with current staging. The codestyle issues which went in with the 3.4.6 release are now fixed.

@Bakual Done

@klas, how can I test this exactly.
Then I can ask PBF visitors to test this PR.

@conconnl getSuperUsers fuction behaviour should stay the same, what specifically you can test is that the same set of superusers gets email notification about update than before patch (emails are sent either to superusers with emails matching those from the list or all superusers, if no emails have been set in the plugin)

@klas I have tried to test it but can't seem to trigger the update mails.
I manually changed the version numbers in the files, but the update mechanism in Joomla can't find a update even when I use 3.4.0 as number.

I you know which changes are needed to trigger it, then I would gladly test it again.

I have tested this item ✅ successfully on 91d4e47

First I tried to trigger the update notification by manually change the version string.
This step worked worked and the backend popup to update. But it didn't send an email to the superuser (pre-patch).
So I vardumpped the codenotification.php return values that are affected by the patch and compared them with the return values of the patched code.
Pre- and postpatch returned the same values.

@icampus

I have tested this item ✅ successfully on 91d4e47

changed the version in database and cleared cache. dumped the return information from ./plugins/system/updatenotification/updatenotification.php

both looked the same. @icampus

RTC as we have 2 successful tests

Thank you all for testing