Tinymce code icon in simple view#11657
Merged
wilsonge merged 6 commits intojoomla:stagingfrom Aug 18, 2016
brianteeman:tinymce
Merged
Tinymce code icon in simple view#11657wilsonge merged 6 commits intojoomla:stagingfrom brianteeman:tinymce
wilsonge merged 6 commits intojoomla:stagingfrom
brianteeman:tinymce
Conversation
This reverts commit 8f995f1.
Contributor
|
I have tested this item ✅ successfully on bfde487 also it does look better with this change This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11657. |
Contributor
|
I have tested this item ✅ successfully on bfde487 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11657. |
Contributor
|
RTC Thanks @brianteeman |
|
I have tested this item ✅ successfully on bfde487 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11657. |
ggppdk
pushed a commit
to ggppdk/joomla-cms
that referenced
this pull request
Aug 19, 2016
* toolbar * Revert "toolbar" This reverts commit 8f995f1. * tinymce code icon on toolbar
roland-d
pushed a commit
to roland-d/joomla-cms
that referenced
this pull request
Sep 11, 2016
* toolbar * Revert "toolbar" This reverts commit 8f995f1. * tinymce code icon on toolbar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Testing Instructions
Switch tinymce into simple functionality
you will see the code editor AFTER the xtd-plugins
Switch tinymce into advanced functionality
you will see the code editor BEFORE the xtd-plugins with the link unlink icons
After the PR the icon will be before the xtd-plugins - see screenshots
Before
After