Blacklist and Whitelist#11330
Conversation
|
I have tested this item ✅ successfully on 38b62d5 On code review This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11330. |
|
I have tested this item ✅ successfully on 38b62d5 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11330. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11330. |
|
|
||
| /** | ||
| * The array of permitted tags (white list). | ||
| * The array of permitted tags (whitelist). |
There was a problem hiding this comment.
Can we revert this and make the change in the framework package please :)
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
Cant update it there as the bug is not present there and the file is very different anyay
There was a problem hiding this comment.
I'm pretty sure I saw that and felt the way that was written was wrong and
fixed it there at some point. Either way as long as it's consistently
correct we're good.
On Thursday, July 28, 2016, Brian Teeman notifications@github.com wrote:
In libraries/vendor/joomla/filter/src/InputFilter.php
#11330 (comment):@@ -30,15 +30,15 @@ class InputFilter
protected static $instances = array();/**
- * The array of permitted tags (white list).
- * The array of permitted tags (whitelist).
Cant update it there as the bug is not present there and the file is very
different anyay—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/joomla/joomla-cms/pull/11330/files/38b62d5391c73a629a04f4f1a0aa52c2c347617d#r72715446,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfoewQOf4b8mcznk1LD8O2SN3BZ91gks5qaS5BgaJpZM4JXMSe
.
|
Removed the commit to the vendor file |
|
Thanks :) |
* blacklist * whitelist * remove vendor
* blacklist * whitelist * remove vendor
It is more normal for these to be one word and not two words. I have updated the words2watch list for this https://joomla.github.io/user-interface-text/?user-interface-text/words2watch.md and this simple PR corrects the core strings and comments