Skip to content

Added tooltip of created date,created by and modified date fields at new/edit tag view#11141

Merged
rdeutz merged 2 commits intojoomla:stagingfrom
RonakParmar:new_tag_missing_tooltip
Aug 13, 2016
Merged

Added tooltip of created date,created by and modified date fields at new/edit tag view#11141
rdeutz merged 2 commits intojoomla:stagingfrom
RonakParmar:new_tag_missing_tooltip

Conversation

@RonakParmar
Copy link
Copy Markdown

@RonakParmar RonakParmar commented Jul 15, 2016 •
edited by brianteeman
Loading

Summary of Changes

Check New/Edit tag view at administrator side.
In "Publishing" tag, there is no tool-tip for Created Date, Created by and Modified date field.
After applying this PR, you can see tool-tip on for these fields.

Testing Instructions

Check New/Edit tag view at administrator side.
In "Publishing" tag, there is no tool-tip for Created Date, Created by and Modified date field.
After applying this PR, you can see tool-tip on for these fields.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Jul 15, 2016
@killoltailored
Copy link
Copy Markdown

killoltailored commented Jul 15, 2016

I have tested this item ✅ successfully on 87599cf

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11141.

@killoltailored
Copy link
Copy Markdown

killoltailored commented Jul 15, 2016

Tested successfully with Joomla Version: Joomla! 3.6.0 Stable [ Noether ] 12-July-2016 21:14 GMT
And System Windows 8.1, browser: Firefox 47.0.1
screen shot 2016-07-15 at 01 08 32screen shot 2016-07-15 at 01 08 45

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11141.

@grhcj
Copy link
Copy Markdown

grhcj commented Jul 15, 2016

I have not tested this item.

@RonakParmar Is there any reason why you didn't add a tooltip for "Modified By"?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11141.

@RonakParmar
Copy link
Copy Markdown
Author

RonakParmar commented Jul 15, 2016

I have checked that there is no tool-tip for "Modified By" in Article, Category, Featured Article, Banner, News Feed, Contact pages, This is the reason I do not added tooltip for Modified By field.

@grhcj
Copy link
Copy Markdown

grhcj commented Jul 15, 2016

I have tested this item ✅ successfully on 87599cf

OK then.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11141.

@killoltailored
Copy link
Copy Markdown

killoltailored commented Jul 19, 2016

I have tested this item ✅ successfully on 5e479ba

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11141.

@grhcj
Copy link
Copy Markdown

grhcj commented Jul 19, 2016

I have tested this item ✅ successfully on 5e479ba

On Review (only language string changes since my last test).

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11141.

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

andrepereiradasilva commented Jul 19, 2016

I have tested this item ✅ successfully on 5e479ba

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11141.

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Jul 21, 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11141.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 21, 2016
@brianteeman brianteeman added this to the Joomla 3.6.1 milestone Jul 21, 2016
@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Jul 21, 2016

Can you fix the conflicts here please :)

@RonakParmar RonakParmar force-pushed the new_tag_missing_tooltip branch from 5e479ba to 2a21b2f Compare July 22, 2016 04:04
@RonakParmar
Copy link
Copy Markdown
Author

RonakParmar commented Jul 22, 2016

Thanks @wilsonge I have resolved conflicts.

@sonalitailored
Copy link
Copy Markdown

sonalitailored commented Jul 22, 2016

I have tested this item successfully

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11141.

@wilsonge wilsonge modified the milestones: Joomla 3.6.2, Joomla 3.6.1 Jul 25, 2016
@rdeutz rdeutz merged commit d1aa917 into joomla:staging Aug 13, 2016
@brianteeman brianteeman removed the RTC This Pull Request is Ready To Commit label Aug 13, 2016
ggppdk pushed a commit to ggppdk/joomla-cms that referenced this pull request Aug 19, 2016
@ggppdk
Added tooltip of created date,created by and modified date fields at …
fa0aca0 
…new/edit tag view (joomla#11141)

* Added tooltip of created date,created by and modified date fields at tag new/edit view

* Modified created by description text and set language string in alpha order
roland-d pushed a commit to roland-d/joomla-cms that referenced this pull request Sep 11, 2016
@roland-d
Added tooltip of created date,created by and modified date fields at …
a6984c0 
…new/edit tag view (joomla#11141)

* Added tooltip of created date,created by and modified date fields at tag new/edit view

* Modified created by description text and set language string in alpha order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Language Change This is for Translators

Projects

None yet

Milestone

Joomla 3.6.3

Development

Successfully merging this pull request may close these issues.

9 participants

@RonakParmar @killoltailored @grhcj @andrepereiradasilva @brianteeman @wilsonge @sonalitailored @rdeutz @joomla-cms-bot