Skip to content

Fix for #11521 : Isis admin menu on small viewport width devices#11528

Merged
rdeutz merged 3 commits intojoomla:stagingfrom
cyrez:patch-34
Aug 16, 2016
Merged

Fix for #11521 : Isis admin menu on small viewport width devices#11528
rdeutz merged 3 commits intojoomla:stagingfrom
cyrez:patch-34

Conversation

@cyrez
Copy link
Copy Markdown
Contributor

@cyrez cyrez commented Aug 9, 2016

Pull Request for Issue #11521 .

Summary of Changes

Do not run auto-scolling script on small devices ( < 768px)

Testing Instructions

  • Apply patch
  • Clear browser cache
  • Test usability of admin main menu on mobile (iPhone, Android...), or on screen resized with a width smaller than 768px (to have main Hamburger icon menu).
  • Nothing should be changed when width is higger than 767px (auto-scrolling)

Do not run auto-scrolling on small devices for Isis admin menu
@brianteeman
Copy link
Copy Markdown
Contributor

Testers do not forget to clear your browser cache after applying this patch. It can be tricky on some mobile devices.

@brianteeman
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on

Tested on several android devices and an iphone emulator. All confirmed the issue and that the patch resolved it


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11528.


});


Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason for this extra clean line? ;)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well... no reason...
Removed ;-)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, i think i added it as there were 2 lines to open a new task function here : https://github.com/joomla/joomla-cms/pull/11528/files#diff-6337832bd45e0f9af1521049cb78e03eR182

Should i remove the extra one too there, even if it was already there, to get all consistent ?

@brianteeman
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on abed882


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11528.

1 similar comment
@ggppdk
Copy link
Copy Markdown
Contributor

ggppdk commented Aug 15, 2016

I have tested this item ✅ successfully on abed882


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11528.

@brianteeman
Copy link
Copy Markdown
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11528.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 15, 2016
@brianteeman brianteeman added this to the Joomla 3.6.3 milestone Aug 15, 2016
@rdeutz rdeutz merged commit 261c63d into joomla:staging Aug 16, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 16, 2016
ggppdk pushed a commit to ggppdk/joomla-cms that referenced this pull request Aug 19, 2016
joomla#11528)

* Fix for joomla#11521 : Isis admin menu on small viewport width devices

Do not run auto-scrolling on small devices for Isis admin menu

* Adjust min-width for auto-scrolling

* Remove extra empty line
roland-d pushed a commit to roland-d/joomla-cms that referenced this pull request Sep 11, 2016
joomla#11528)

* Fix for joomla#11521 : Isis admin menu on small viewport width devices

Do not run auto-scrolling on small devices for Isis admin menu

* Adjust min-width for auto-scrolling

* Remove extra empty line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants