Merged
Conversation
The $idField is never used throughout the code, seems to be an attempt to sanitize the id. I've added some more filtering to produce a usable id.
Contributor
|
this should be faster: $id = str_replace('[', '_', substr(trim($name), 0, -1)); |
Contributor
Author
|
Should be faster, but it doesn't cover all options:
|
Contributor
|
Agree! |
Contributor
|
I have tested this item ✅ successfully on 9f65523 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11192. |
|
I have tested this item ✅ successfully on 9f65523 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11192. |
Contributor
|
RTC @wilsonge can you merge this one for 3.6.1 ? |
ggppdk
pushed a commit
to ggppdk/joomla-cms
that referenced
this pull request
Aug 19, 2016
The $idField is never used throughout the code, seems to be an attempt to sanitize the id. I've added some more filtering to produce a usable id.
roland-d
pushed a commit
to roland-d/joomla-cms
that referenced
this pull request
Sep 11, 2016
The $idField is never used throughout the code, seems to be an attempt to sanitize the id. I've added some more filtering to produce a usable id.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #11190 .
Summary of Changes
The
$idFieldvariable is never used throughout the code, seems to be an attempt to sanitize the$id. I've added some more filtering to produce a usable id. Should work for multiple editors as well.Testing Instructions
Testing instructions can be found in the issue description.