Skip to content

Contact "Image" column parameter in the Beez override: #10902#10912

Closed
AlexRed wants to merge 2 commits intojoomla:stagingfrom
AlexRed:patch-14
Closed

Contact "Image" column parameter in the Beez override: #10902#10912
AlexRed wants to merge 2 commits intojoomla:stagingfrom
AlexRed:patch-14

Conversation

@AlexRed
Copy link
Copy Markdown
Contributor

@AlexRed AlexRed commented Jun 23, 2016

Pull Request for Issue #10901 .

Summary of Changes

Added ,1 to the parameters in beez template override to make them show without the need of saving Options

Testing Instructions

Create some contacts and assign an Image to the contacts. Create a menu item type "List Contacts in a Category". In Components > Contacts > Options > List Layouts look the parameter "Image", it is set to Show.
Look in frontend with beez template the menu item you created and will see that the image column now is present (and also the filters).

 Contact "Image" column parameter in the Beez override: joomla#10902
@infograf768
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on ba7de12


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10912.

@infograf768
Copy link
Copy Markdown
Member

This goes with #10902

@brianteeman brianteeman changed the title Contact "Image" column parameter in the Beez override: #10902 Contact "Image" column parameter in the Beez override: #10902 Jun 23, 2016
@brianteeman
Copy link
Copy Markdown
Contributor

Could you fix the codestyle bugs please

FILE: .../joomla-cms/templates/beez3/html/com_contact/category/default_items.php

FOUND 3 ERROR(S) AFFECTING 3 LINE(S)

22 | ERROR | No space found after comma in function call
36 | ERROR | No space found after comma in function call
101 | ERROR | No space found after comma in function call


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10912.

@joomla-cms-bot
Copy link
Copy Markdown

This PR has received new commits.

CC: @infograf768


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10912.

@brianteeman
Copy link
Copy Markdown
Contributor

Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10912.

@infograf768
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on 33b00ee


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10912.

1 similar comment
@brianteeman
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 33b00ee


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10912.

@brianteeman
Copy link
Copy Markdown
Contributor

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10912.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 23, 2016
@brianteeman brianteeman added this to the Joomla 3.6.1 milestone Jul 13, 2016
@roland-d
Copy link
Copy Markdown
Contributor

roland-d commented Jul 16, 2016

I am not seeing the search field in Beez:

screen shot 2016-07-16 at 10 06 32

while I do see it in Protostar #10902 (comment)

@AlexRed
Copy link
Copy Markdown
Contributor Author

AlexRed commented Jul 30, 2016

yes, no search field code in the beez template override, I can't add ,1 to the search field parameter. No search field code

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 30, 2016
@wilsonge wilsonge removed this from the Joomla 3.6.1 milestone Aug 2, 2016
AlexRed added a commit to AlexRed/joomla-cms that referenced this pull request Aug 17, 2016
Pull Request for Issue joomla#10901

the old PR  joomla#10901 and  joomla#10912  seems inadeguate :(

Summary of Changes
Set hide by default the parameter which have no effect until the first saving
wilsonge pushed a commit that referenced this pull request Aug 17, 2016
Pull Request for Issue #10901

the old PR  #10901 and  #10912  seems inadeguate :(

Summary of Changes
Set hide by default the parameter which have no effect until the first saving
@AlexRed
Copy link
Copy Markdown
Contributor Author

AlexRed commented Aug 18, 2016

Please close. Related Pull request #11640 successfully merged.

@rdeutz
Copy link
Copy Markdown
Contributor

rdeutz commented Aug 18, 2016

closing as requested

@rdeutz rdeutz closed this Aug 18, 2016
ggppdk pushed a commit to ggppdk/joomla-cms that referenced this pull request Aug 19, 2016
Pull Request for Issue joomla#10901

the old PR  joomla#10901 and  joomla#10912  seems inadeguate :(

Summary of Changes
Set hide by default the parameter which have no effect until the first saving
roland-d pushed a commit to roland-d/joomla-cms that referenced this pull request Sep 11, 2016
Pull Request for Issue joomla#10901

the old PR  joomla#10901 and  joomla#10912  seems inadeguate :(

Summary of Changes
Set hide by default the parameter which have no effect until the first saving
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants