Skip to content

Contact "Image" column parameter:#10902

Closed
AlexRed wants to merge 1 commit intojoomla:stagingfrom
AlexRed:patch-13
Closed

Contact "Image" column parameter:#10902
AlexRed wants to merge 1 commit intojoomla:stagingfrom
AlexRed:patch-13

Conversation

@AlexRed
Copy link
Copy Markdown
Contributor

@AlexRed AlexRed commented Jun 22, 2016 •
edited by joomla-cms-bot
Loading

Pull Request for Issue #10901 .

Summary of Changes

Added ,1 to the parameters to make them show without the need of saving Options

Testing Instructions

Create some contacts and assign an Image to the contacts. Create a menu item type "List Contacts in a Category". In Components > Contacts > Options > List Layouts look the parameter "Image", it is set to Show.
Look in frontend the menu item you created and will see that the image column now is present (and also the filters).

@AlexRed
Update default_items.php
455f7c9 
This PR solves issue tracker joomla#10901, now the image and the filters show without the need of saving
@brianteeman brianteeman mentioned this pull request Jun 22, 2016
Closed
@brianteeman brianteeman changed the title Update default_items.php Contact "Image" column parameter Jun 22, 2016
@brianteeman brianteeman changed the title Contact "Image" column parameter Contact "Image" column parameter: Jun 22, 2016
@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Jun 23, 2016 •
edited
Loading

@AlexRed
Can you also correct Beez?

@AlexRed
Copy link
Copy Markdown
Contributor Author

AlexRed commented Jun 23, 2016

sorry JM but I don't understand your request, ...I know I'm an idiot :)
I tryed in Beez and I see the image column.

AlexRed added a commit to AlexRed/joomla-cms that referenced this pull request Jun 23, 2016
@AlexRed
Contact "Image" column parameter in the Beez override: joomla#10902
ba7de12 
 Contact "Image" column parameter in the Beez override: joomla#10902
@AlexRed
Copy link
Copy Markdown
Contributor Author

AlexRed commented Jun 23, 2016 •
edited
Loading

ok, found how to correct it, see PR #10912

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Jun 23, 2016

I have tested this item ✅ successfully on 455f7c9

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10902.

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Jun 23, 2016

To maintainers:
#10912 and this #10902 should be merged together

@infograf768 infograf768 mentioned this pull request Jun 23, 2016
Closed
@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Jun 23, 2016

I have tested this item ✅ successfully on 455f7c9

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10902.

@brianteeman brianteeman changed the title Contact "Image" column parameter: Contact "Image" column parameter: Jun 23, 2016
@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Jun 23, 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10902.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 23, 2016
@brianteeman brianteeman added this to the Joomla 3.6.1 milestone Jul 13, 2016
@roland-d
Copy link
Copy Markdown
Contributor

roland-d commented Jul 16, 2016

@AlexRed The search field shows as explained but I think we are missing the search and clear button as seen in this field from the tags page:

screen shot 2016-07-16 at 10 01 54

I believe that should be added for consistency. Now I see this after applying the patch:
screen shot 2016-07-16 at 10 07 43

@AlexRed
Copy link
Copy Markdown
Contributor Author

AlexRed commented Jul 30, 2016

It is a good idea also to set search and clear button, but I can't find it in the file. How can I edit the PR for set search and clear button ?

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 30, 2016
@wilsonge wilsonge removed this from the Joomla 3.6.1 milestone Aug 2, 2016
@roland-d
Copy link
Copy Markdown
Contributor

roland-d commented Aug 16, 2016

@AlexRed I don't know from the top of my head but you can of course check the code from the tags page and how it is done there.

@AlexRed
Copy link
Copy Markdown
Contributor Author

AlexRed commented Aug 16, 2016

sorry, but also I don't know how to do it

@roland-d
Copy link
Copy Markdown
Contributor

roland-d commented Aug 16, 2016

I don't have time to do it for you. Perhaps someone else can help you with that.

@AlexRed
Copy link
Copy Markdown
Contributor Author

AlexRed commented Aug 16, 2016

It is not for me, it is for all Joomla community.
But if you don't like my Pull Request to solve Issue #10901 you can close it.

@roland-d
Copy link
Copy Markdown
Contributor

roland-d commented Aug 16, 2016

@AlexRed I never said I don't like the PR, I actually tested it but found an inconsistency. You can't demand from me to write the code for it.

@AlexRed AlexRed mentioned this pull request Aug 18, 2016
Merged
@AlexRed
Copy link
Copy Markdown
Contributor Author

AlexRed commented Aug 18, 2016

Please close. Related Pull request #11640 successfully merged.

@rdeutz
Copy link
Copy Markdown
Contributor

rdeutz commented Aug 18, 2016

@AlexRed you should be able to close your PR as far as I know. I hit the button for you :-)

@rdeutz rdeutz closed this Aug 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@AlexRed @infograf768 @brianteeman @roland-d @rdeutz @wilsonge @joomla-cms-bot