Contact default parameter (images, filter, pagination)#11640
Merged
wilsonge merged 1 commit intojoomla:stagingfrom Aug 17, 2016
Merged
Contact default parameter (images, filter, pagination)#11640wilsonge merged 1 commit intojoomla:stagingfrom
wilsonge merged 1 commit intojoomla:stagingfrom
Conversation
Pull Request for Issue joomla#10901 the old PR joomla#10901 and joomla#10912 seems inadeguate :( Summary of Changes Set hide by default the parameter which have no effect until the first saving
|
I have tested this item ✅ successfully on This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11640. |
1 similar comment
Member
|
I have tested this item ✅ successfully on This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11640. |
Contributor
|
The default values in the PHP code using these params should be changed too for this to be accepted. |
Contributor
Author
|
an indication, an help please. Where are the PHP code using these params? |
Contributor
|
@mbabker The point of this PR is to get the default values in the XML inline with the ones in the PHP code (where there is none specified, so |
Contributor
|
Well that would've been good to point out 😉 |
Contributor
Author
|
😄😄😄 |
Member
|
Can we go to RTC? |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11640. |
This was referenced Aug 18, 2016
ggppdk
pushed a commit
to ggppdk/joomla-cms
that referenced
this pull request
Aug 19, 2016
Pull Request for Issue joomla#10901 the old PR joomla#10901 and joomla#10912 seems inadeguate :( Summary of Changes Set hide by default the parameter which have no effect until the first saving
roland-d
pushed a commit
to roland-d/joomla-cms
that referenced
this pull request
Sep 11, 2016
Pull Request for Issue joomla#10901 the old PR joomla#10901 and joomla#10912 seems inadeguate :( Summary of Changes Set hide by default the parameter which have no effect until the first saving
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #10901 .
Summary of Changes
Set hide by default the parameter which have no effect until the first saving
Testing Instructions
Set hide by default the parameter which have no effect until the first saving: Filter Field, Display Select, Image, in the TAB "List Layouts" for the Contacts: Options
Documentation Changes Required
the old PR #10902 and #10912 seems inadeguate for the team :(