Solve PHP Notice when saving as copy a menu item#11647
Merged
wilsonge merged 2 commits intojoomla:stagingfrom Aug 17, 2016
Merged
Solve PHP Notice when saving as copy a menu item#11647wilsonge merged 2 commits intojoomla:stagingfrom
wilsonge merged 2 commits intojoomla:stagingfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11647. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11647. |
Member
|
I have tested this item ✅ successfully on 65fab4a This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11647. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11647. |
Member
|
Please test #11664 |
ggppdk
pushed a commit
to ggppdk/joomla-cms
that referenced
this pull request
Aug 19, 2016
* we need isset here to not have a php notice * Update item.php
roland-d
pushed a commit
to roland-d/joomla-cms
that referenced
this pull request
Sep 11, 2016
* we need isset here to not have a php notice * Update item.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
There is a PHP Notice (check php error logs) when saving a menu as copy a menu item.
Testing Instructions
PHP Notice: Undefined index: associations in /path/to/joomla/administrator/components/com_menus/models/item.php on line 1384Documentation Changes Required
None
Notes
Found in GsoC multilingual
If this ok will do the same for the other components that have the same issue.