Skip to content

Fixed mistake after 11265#11641

Merged
wilsonge merged 2 commits intojoomla:stagingfrom
jeckodevelopment:jeckodevelopment-modcachelng
Aug 17, 2016
Merged

Fixed mistake after 11265#11641
wilsonge merged 2 commits intojoomla:stagingfrom
jeckodevelopment:jeckodevelopment-modcachelng

Conversation

@jeckodevelopment
Copy link
Copy Markdown
Member

@jeckodevelopment jeckodevelopment commented Aug 17, 2016

Pull Request to fix mistake in comment after #11265 .

Summary of Changes

en-GB.mod_languages.ini line 9

Testing Instructions

Code review

Documentation Changes Required

None

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Aug 17, 2016
@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented Aug 17, 2016

I have tested this item ✅ successfully on 22372b2

looks better now 😄


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11641.

@yvesh
Copy link
Copy Markdown
Member

yvesh commented Aug 17, 2016

I have tested this item ✅ successfully on 22372b2


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11641.

@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented Aug 17, 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11641.

1 similar comment
@jeckodevelopment
Copy link
Copy Markdown
Member Author

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11641.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 17, 2016
@jeckodevelopment
Copy link
Copy Markdown
Member Author

@zero-24 we marked it as RTC at the same time :)

@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented Aug 17, 2016

double RTC is better :P

@wilsonge wilsonge merged commit bc2be0c into joomla:staging Aug 17, 2016
@wilsonge wilsonge added this to the Joomla 3.6.3 milestone Aug 17, 2016
@jeckodevelopment jeckodevelopment deleted the jeckodevelopment-modcachelng branch August 17, 2016 22:08
@Hils
Copy link
Copy Markdown
Contributor

Hils commented Aug 18, 2016

MOD_LANGUAGES_FIELD_DROPDOWN_DESC="If set to 'Yes', the content languages native names will display in a dropdown."
Shouldn't 'languages' have an apostrophe (location dependent upon plural or singular) as it is possessive? (ie the names of the native languages)
Should I put this in a separate PR?

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 18, 2016
@jeckodevelopment
Copy link
Copy Markdown
Member Author

Hey Hils,
Yes please, open a separate PR since this has been merged.

ggppdk pushed a commit to ggppdk/joomla-cms that referenced this pull request Aug 19, 2016
* Fixed mistake after 11265

* Missing dot
roland-d pushed a commit to roland-d/joomla-cms that referenced this pull request Sep 11, 2016
* Fixed mistake after 11265

* Missing dot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants