Admin status module updates by C-Lodder · Pull Request #10918 · joomla/joomla-cms

C-Lodder · 2016-06-23T15:27:35Z

Pull Request for Issue #10910

Summary of Changes

Removes "envelope" icon
Adds "Message(s)" label after the count badge
Adds separators in between each button group

Testing Instructions

Very simple. Apply the patch and match again the screenshots below:

Before:

After:

MATsxm · 2016-06-23T15:42:18Z

I have tested this item ✅ successfully on d5320ba

👍

I love this way. Thanks

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10918.}

MATsxm · 2016-06-23T15:44:41Z

Side note, see with Multilingual Sites...
Is there a way for a "conditional" separator?

joomla-cms-bot · 2016-06-23T15:56:11Z

This PR has received new commits.

CC: @MATsxm

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10918.}

C-Lodder · 2016-06-23T15:56:35Z

@MATsxm - done ;)

andrepereiradasilva · 2016-06-23T16:11:44Z

I have tested this item 🔴 unsuccessfully on 73aff5a

doesn't work on RTL languages (Arabic for instance).

also it seems generatecss.php has not run to generate the css from less files.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10918.}

brianteeman · 2016-06-23T16:17:13Z

administrator/modules/mod_status/tmpl/default.php

-		. '<span class="icon-envelope"></span>'
-		. '<span class="badge' . $active . '">' . $unread . '</span>'
+		. '<span class="badge' . $active . '">' . $unread . '</span> '
+		. JText::plural('MOD_STATUS_MESSAGES_LABEL', $unread)


Can you look at removing the space please so that the link is not " messages" but "messages"

You will see the logout link is ok

brianteeman · 2016-06-23T16:18:48Z

After applying the PR my site doesnt look exactly the same as your screenshot. The separator is not evenly spaced

MATsxm · 2016-06-23T16:21:46Z

I have tested this item ✅ successfully on 73aff5a

Works fine here with the multilingual mod_ enabled.

Didn't test on RTL

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10918.}

brianteeman · 2016-06-23T16:31:57Z

When you only have multilingual mod enabled you have a seperator hanging on
its own

On 23 June 2016 at 17:21, Marc-Antoine Thevenet notifications@github.com
wrote:

I have tested this item ✅ successfully on 73aff5a
73aff5a

Works fine here with the multilingual mod_ enabled.

Didn't test on RTL

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/10918
https://issues.joomla.org/tracker/joomla-cms/10918.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#10918 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8YbIJMts9eGDNSuxuRHY9O3dZQZDks5qOrKdgaJpZM4I87vN
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

ggppdk · 2016-06-23T17:27:43Z

When you only have multilingual mod enabled you have a seperator hanging on its own

Yes, because it is a different module maybe better remove it from this module

About RTL it works, if you copy new CSS into the RTL css file (or into the less files),

About extra spacing in seperators it is because of isis CSS rule:

.btn-group + .btn-group {
    margin-left: 5px;
}

And in RTL same effect with extra spacing seperators is because of isis CSS rule:

 .btn-group + .btn-group {
    margin-right: 5px;
    margin-left: 0px;
}

we could add this to fix it:

#status .btn-group + .btn-group {
    margin: 0px;
}

But it seems like and unneeded hack to do this, because the seperator is inside the btn-group, i have tested moving the separator out of the btn-group:

//...  Remove seperator from all $output[] and then:

// Output the items.
/*foreach ($output as $item)
{
    echo $item;
}*/

echo implode('<span class="btn-group separator"></span>', $output);

and the result is proper in both cases (RTL, non-RTL)

infograf768 · 2016-06-24T08:12:23Z

Concerning Messages, I guess the tooltip is no more necessary.

C-Lodder · 2016-06-24T08:12:55Z

@infograf768 - I used new language strings bacause the ones already provided add a number to the beginning of the string, hence the %d. The number is already shown in the badge so no need to show it again.

I'll double check on RTL....always forget this

infograf768 · 2016-06-24T08:14:18Z

@C-Lodder
Yep, saw that and deleted my post. ;)
but I still think the tooltip is now useless.

joomla-cms-bot · 2016-06-24T09:39:19Z

This PR has received new commits.

CC: @andrepereiradasilva, @MATsxm

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10918.}

C-Lodder · 2016-06-24T09:40:06Z

I've now applied the change to RTL languages and also fixed the whitespace issue as mentioned by @brianteeman

Oh and removed the tooltip

joomla-cms-bot · 2016-06-24T09:43:54Z

This PR has received new commits.

CC: @andrepereiradasilva, @MATsxm

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10918.}

brianteeman · 2016-06-24T09:44:35Z

I have tested this item ✅ successfully on 6d6544e

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10918.}

brianteeman · 2016-06-24T09:49:50Z

Sorry to be a pain but because of some stupid rules we dont remove unused strings

joomla-cms-bot · 2016-06-24T10:26:28Z

This PR has received new commits.

CC: @andrepereiradasilva, @brianteeman, @MATsxm

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10918.}

C-Lodder · 2016-06-24T10:27:23Z

Added them back in.

Why on earth are language strings that are no longer used not removed?

joomla-cms-bot · 2016-06-27T08:11:07Z

This PR has received new commits.

CC: @andrepereiradasilva, @brianteeman, @MATsxm

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10918.}

C-Lodder · 2016-06-27T08:12:45Z

@infograf768 - alpha ordered the language strings. No idea what you mean by the generatecss.php. I didn't touch this at all. I simply forked the latest, made my changes, then compiled the LESS using the button in the Isis toolbar

infograf768 · 2016-06-28T08:32:43Z

When you modify a .less file you have to run a CLI called generatecss.php, NOT use the Isis compilation.
I.e. cd to your local repository (on Mac it is called Terminal) and enter
php build/generatecss.php
It will do the job for you on the .css files.

C-Lodder · 2016-06-28T09:14:44Z

@infograf768 - Erm ok, never heard about this before, nor have I ever done it. Is there some sort of "Contributing guidelines" wiki that I can refer to for future reference?

infograf768 · 2016-06-28T09:27:48Z

That's for Macintosh
http://www.macworld.co.uk/feature/mac-software/get-more-out-of-os-x-terminal-3608274/
for Linux
https://www.linux.com/learn/how-use-linux-command-line-basics-cli
I guess for windows
http://www.bleepingcomputer.com/tutorials/windows-command-prompt-introduction/

C-Lodder · 2016-06-28T09:30:00Z

I don't mean that. I mean a guideline as to what steps to take when contributing to Joomla. Where does it say that people need to build the generatecss.php?

mbabker · 2016-06-28T12:18:44Z

It doesn't say it explicitly anywhere but if you make a change to any LESS file in core you should run the generatecss.php script to ensure all resources are correctly updated. Since your changes only affect Isis it probably isn't a major issue this time but if you changed something in the media directory as an example it would affect multiple templates.

wilsonge · 2016-07-21T21:15:41Z

@C-Lodder I can't merge this until you run the generatecss.php stuff. I can run you through it if it helps?

wilsonge · 2016-07-21T21:17:56Z

I'm removing the RTC label for now

C-Lodder · 2016-07-21T22:30:44Z

@wilsonge I'll run it tomorrow

C-Lodder · 2016-07-22T07:58:33Z

@wilsonge - all done

wilsonge · 2016-07-25T09:09:12Z

RTC

wilsonge · 2016-07-25T09:10:04Z

Bad bot

zero-24 · 2016-08-13T17:07:09Z

Come on @joomla-cms-bot

* Admin status module updates * Added separator + removed class for multilingual status label * Moved separator element inside button group container * Removed tooltip * Fixed on RTL + removed whitespace * Removed old language strings for tooltip * Re-added tooltip language strings * order language strings alphabetically * Build generatecss.php

Admin status module updates

d5320ba

joomla-cms-bot added Language Change This is for Translators PR-staging labels Jun 23, 2016

C-Lodder added 2 commits June 23, 2016 16:54

Added separator + removed class for multilingual status label

06e5c41

Moved separator element inside button group container

73aff5a

brianteeman mentioned this pull request Jun 23, 2016

Admin Status module #10910

Closed

brianteeman reviewed Jun 23, 2016
View reviewed changes

C-Lodder added 2 commits June 24, 2016 10:04

Removed tooltip

949ceb1

Fixed on RTL + removed whitespace

8d8127a

Removed old language strings for tooltip

6d6544e

Re-added tooltip language strings

f14c5a4

order language strings alphabetically

f2a8709

Merge remote-tracking branch 'upstream/staging' into adminstatus

8321bc0

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 21, 2016

wilsonge removed this from the Joomla 3.6.1 milestone Jul 21, 2016

Build generatecss.php

3fc1cc4

wilsonge added this to the Joomla 3.6.2 milestone Jul 25, 2016

wilsonge added the RTC This Pull Request is Ready To Commit label Jul 25, 2016

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 25, 2016

joomla-cms-bot removed this from the Joomla 3.6.2 milestone Jul 25, 2016

wilsonge added the RTC This Pull Request is Ready To Commit label Jul 25, 2016

wilsonge added this to the Joomla 3.6.2 milestone Jul 25, 2016

rdeutz merged commit 1ede964 into joomla:staging Aug 13, 2016

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 13, 2016

C-Lodder deleted the adminstatus branch August 14, 2016 10:06

Uh oh!

Conversation

C-Lodder commented Jun 23, 2016 • edited by joomla-cms-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Testing Instructions

Uh oh!

MATsxm commented Jun 23, 2016

Uh oh!

MATsxm commented Jun 23, 2016

Uh oh!

joomla-cms-bot commented Jun 23, 2016

Uh oh!

C-Lodder commented Jun 23, 2016

Uh oh!

andrepereiradasilva commented Jun 23, 2016

Uh oh!

brianteeman Jun 23, 2016

Choose a reason for hiding this comment

Uh oh!

brianteeman Jun 23, 2016

Choose a reason for hiding this comment

Uh oh!

brianteeman commented Jun 23, 2016

Uh oh!

MATsxm commented Jun 23, 2016

Uh oh!

brianteeman commented Jun 23, 2016

Didn't test on RTL

Uh oh!

ggppdk commented Jun 23, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

infograf768 commented Jun 24, 2016

Uh oh!

C-Lodder commented Jun 24, 2016

Uh oh!

infograf768 commented Jun 24, 2016

Uh oh!

joomla-cms-bot commented Jun 24, 2016

Uh oh!

C-Lodder commented Jun 24, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joomla-cms-bot commented Jun 24, 2016

Uh oh!

brianteeman commented Jun 24, 2016

Uh oh!

brianteeman commented Jun 24, 2016

Uh oh!

joomla-cms-bot commented Jun 24, 2016

Uh oh!

C-Lodder commented Jun 24, 2016

Uh oh!

joomla-cms-bot commented Jun 27, 2016

Uh oh!

C-Lodder commented Jun 27, 2016

Uh oh!

infograf768 commented Jun 28, 2016

Uh oh!

C-Lodder commented Jun 28, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

infograf768 commented Jun 28, 2016

Uh oh!

C-Lodder commented Jun 28, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mbabker commented Jun 28, 2016

Uh oh!

wilsonge commented Jul 21, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wilsonge commented Jul 21, 2016

Uh oh!

C-Lodder commented Jul 21, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

C-Lodder commented Jul 22, 2016

Uh oh!

C-Lodder commented Jun 23, 2016 •

edited by joomla-cms-bot

Loading

ggppdk commented Jun 23, 2016 •

edited

Loading

C-Lodder commented Jun 24, 2016 •

edited

Loading

C-Lodder commented Jun 28, 2016 •

edited

Loading

C-Lodder commented Jun 28, 2016 •

edited

Loading

wilsonge commented Jul 21, 2016 •

edited

Loading

C-Lodder commented Jul 21, 2016 •

edited

Loading