Remove colon from tooltip#11385
Merged
rdeutz merged 2 commits intojoomla:stagingfrom Aug 13, 2016
brianteeman:colon
Merged
Conversation
Member
|
I have tested this item ✅ successfully on bac8547 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11385. |
1 similar comment
|
I have tested this item ✅ successfully on bac8547 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11385. |
Contributor
Author
|
Rtc thanks for testing This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11385. |
Member
|
I am not sure using "COM_CONTENT_NUM_ITEMS_DESC" makes sense here as we usually keep this for forms. |
Contributor
Author
|
didnt spot we had a _TIP I will make that change - thanks |
Member
|
I have tested this item ✅ successfully on 6eb48df This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11385. |
1 similar comment
Member
|
I have tested this item ✅ successfully on 6eb48df This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11385. |
ggppdk
pushed a commit
to ggppdk/joomla-cms
that referenced
this pull request
Aug 19, 2016
* Remove colon from tooltip * Use tip instead of desc
roland-d
pushed a commit
to roland-d/joomla-cms
that referenced
this pull request
Sep 11, 2016
* Remove colon from tooltip * Use tip instead of desc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue 11382
Summary of Changes
We were using the same string for both the tooltip where it would just say Article Count
and for the more visible string where it would say Article Count: 99
To fix this I created a new string to be used for the tooltip without the colon