Skip to content

[installation] Add language var missing in latest merge (PR 11254)#11263

Merged
rdeutz merged 5 commits intojoomla:stagingfrom
andrepereiradasilva:patch-7
Aug 13, 2016
Merged

[installation] Add language var missing in latest merge (PR 11254)#11263
rdeutz merged 5 commits intojoomla:stagingfrom
andrepereiradasilva:patch-7

Conversation

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

@andrepereiradasilva andrepereiradasilva commented Jul 23, 2016 •
edited by joomla-cms-bot
Loading

Pull Request for New Issue.

Summary of Changes

I forgot to add the new language var (INSTL_DEFAULTLANGUAGE_COULD_NOT_ADD_ASSOCIATIONS) in #11254

So this PR adds the forgotten new language vars in 69fd2dd#diff-20fa161d539804c0cc96d450ab7ee7a1R194

Also adds missing dots to the end of the other error sentences.

Testing Instructions

Code review

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Jul 23, 2016
@andrepereiradasilva andrepereiradasilva changed the title [installation] Add language var missing in latest merge PR 11254) [installation] Add language var missing in latest merge (PR 11254) Jul 23, 2016
@andrepereiradasilva
Copy link
Copy Markdown
Contributor Author

andrepereiradasilva commented Jul 23, 2016 •
edited
Loading

@infograf768 @brianteeman please check the text

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Jul 23, 2016 via email

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Jul 23, 2016

hmm, we were in language freeze and more than that, this is an installation ini string.
@wilsonge please revert #11254

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Jul 23, 2016

can you change all instances of "not able" to "unable"

@infograf768 infograf768 mentioned this pull request Jul 23, 2016
Merged
@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Jul 23, 2016

@andrepereiradasilva rather than revert the #11254 I have changed the current error to a generic error string in e83f468. Can you please revert that change as part of this PR for when this is merged for 3.6.2 (as we are currently in language freeze for 3.6.1)

@andrepereiradasilva
Copy link
Copy Markdown
Contributor Author

andrepereiradasilva commented Jul 23, 2016

OK. Will change later.

@andrepereiradasilva
Copy link
Copy Markdown
Contributor Author

andrepereiradasilva commented Jul 24, 2016

ok done

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Jul 25, 2016

@andrepereiradasilva Please can you do this for consistency

can you change all instances of "not able" to "unable"

@andrepereiradasilva
Copy link
Copy Markdown
Contributor Author

andrepereiradasilva commented Jul 25, 2016

ok @brianteeman done

@jeckodevelopment
Copy link
Copy Markdown
Member

jeckodevelopment commented Jul 25, 2016

I've tested ✅ successfully this item on b7b38b7

@wilsonge wilsonge added this to the Joomla 3.6.2 milestone Jul 25, 2016
brianteeman
brianteeman reviewed Aug 3, 2016
View reviewed changes
installation/language/en-GB/en-GB.ini
INSTL_DEFAULTLANGUAGE_DESC_FRONTEND="Joomla has installed the following languages. Please select your desired default language for the Joomla Frontend."
INSTL_DEFAULTLANGUAGE_FRONTEND="Default Site language"
INSTL_DEFAULTLANGUAGE_FRONTEND_COULDNT_SET_DEFAULT="Joomla was not able to set the language as default. English will be used as default language for the Frontend SITE."
INSTL_DEFAULTLANGUAGE_FRONTEND_COULDNT_SET_DEFAULT="Joomla was unable to set the language as default. English will be used as default language for the Frontend SITE."
Copy link
Copy Markdown
Contributor

@brianteeman brianteeman Aug 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

..as the default language for...

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Aug 5, 2016

I added some comments inline

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11263.

@andrepereiradasilva
Copy link
Copy Markdown
Contributor Author

andrepereiradasilva commented Aug 5, 2016

@brianteeman this PR is not for reviewing installation language strings ...

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Aug 5, 2016

@andrepereiradasilva I am confused then - there are new strings in this PR and they are not correct

@andrepereiradasilva
Copy link
Copy Markdown
Contributor Author

andrepereiradasilva commented Aug 5, 2016

lol the only new string is INSTL_DEFAULTLANGUAGE_COULD_NOT_ADD_ASSOCIATIONS .

The other ones i changed because you asked me before ...

@andrepereiradasilva Please can you do this for consistency
can you change all instances of "not able" to "unable"

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Aug 5, 2016

well lets get them right

On 5 August 2016 at 18:27, andrepereiradasilva notifications@github.com
wrote:

lol the only new string is INSTL_DEFAULTLANGUAGE_COULD_NOT_ADD_ASSOCIATIONS
.

The other ones i changed because you asked me before ...

@andrepereiradasilva https://github.com/andrepereiradasilva Please can
you do this for consistency
can you change all instances of "not able" to "unable"

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11263 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8f46fjZovj-KXxsAPW1qfVZg0tBcks5qc3KXgaJpZM4JTWlA
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@andrepereiradasilva
Copy link
Copy Markdown
Contributor Author

andrepereiradasilva commented Aug 5, 2016

@brianteeman i understand your point, but this needs to get merged in 3.6.3 because there is a missing language string.

you can correct the rest of the language string after this PR is merged.

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Aug 5, 2016 via email

@alikon
Copy link
Copy Markdown
Contributor

alikon commented Aug 6, 2016

I have tested this item ✅ successfully on b7b38b7

on code review

i let english mother tongue people the task to correct the strings if needed

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11263.

@andrepereiradasilva
Copy link
Copy Markdown
Contributor Author

andrepereiradasilva commented Aug 12, 2016

just removed the "!" at @brianteeman request

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Aug 12, 2016

Rtc

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11263.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 12, 2016
@rdeutz rdeutz merged commit 0061fe1 into joomla:staging Aug 13, 2016
@brianteeman brianteeman removed the RTC This Pull Request is Ready To Commit label Aug 13, 2016
@andrepereiradasilva andrepereiradasilva deleted the patch-7 branch August 13, 2016 18:26
ggppdk pushed a commit to ggppdk/joomla-cms that referenced this pull request Aug 19, 2016
@andrepereiradasilva @ggppdk
[installation] Add language var missing in latest merge (PR 11254) (j…
99c7fec 
…oomla#11263)

* add language var

* go back to original language var message in 3.6.2

* "not able" to "unable"

* remove the bag
roland-d pushed a commit to roland-d/joomla-cms that referenced this pull request Sep 11, 2016
@andrepereiradasilva @roland-d
[installation] Add language var missing in latest merge (PR 11254) (j…
88d60dd 
…oomla#11263)

* add language var

* go back to original language var message in 3.6.2

* "not able" to "unable"

* remove the bag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Language Change This is for Translators

Projects

None yet

Milestone

Joomla 3.6.3

Development

Successfully merging this pull request may close these issues.

8 participants

@andrepereiradasilva @brianteeman @infograf768 @wilsonge @jeckodevelopment @alikon @rdeutz @joomla-cms-bot