Skip to content

[installation] Auto-add language associations on multilanguage install#11254

Merged
wilsonge merged 7 commits intojoomla:stagingfrom
andrepereiradasilva:associations-on-install
Jul 23, 2016
Merged

[installation] Auto-add language associations on multilanguage install#11254
wilsonge merged 7 commits intojoomla:stagingfrom
andrepereiradasilva:associations-on-install

Conversation

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

@andrepereiradasilva andrepereiradasilva commented Jul 22, 2016 •
edited by brianteeman
Loading

Summary of Changes

This PR makes installation process auto create the language associations between the items (menu items, categories and articles) when installing a multilanguage site.

Testing Instructions

  1. Download https://github.com/andrepereiradasilva/joomla-cms/archive/associations-on-install.zip (staging + this PR)
  2. Make a new install with this package
    • In the sample data install step, select None (Required for basic native multilingual site creation)
    • Install two or more languages
    • Select to install sample multilingual content
  3. After install, login to backend and check menu items, categories and articles now have the language associations.

image

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Jul 23, 2016

I have tested this item ✅ successfully on 535bf19

Works fine, although associating home pages menu items is not really necessary as these are associated by default without being recorded in the _associations table.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11254.

@dgrammatiko
Copy link
Copy Markdown
Contributor

dgrammatiko commented Jul 23, 2016

@andrepereiradasilva another great improvement! 👍

In the sample data install step, select None (Required for basic native multilingual site creation)

The process is rather counter intuitive from UX perspective. I would suggest to move the sample install data after the multilingual step (maybe a simple yes/no button will reveal the option in the case of mono and hide it till the languages are selected.

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Jul 23, 2016

@DGT41
This would require an important refactoring.
This PR is just for adding associations in the data installed in multingual for the user to understand the process.

@ghost
Copy link
Copy Markdown

ghost commented Jul 23, 2016

I have tested this item ✅ successfully on 535bf19

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11254.

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Jul 23, 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11254.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 23, 2016
@andrepereiradasilva
Copy link
Copy Markdown
Contributor Author

andrepereiradasilva commented Jul 23, 2016

grrr conflicts because of 4 line spaces... will fix ...

@andrepereiradasilva
Copy link
Copy Markdown
Contributor Author

andrepereiradasilva commented Jul 23, 2016

ok conflicts fixed.
IMO no need to retest or remove the RTC

@wilsonge wilsonge merged commit 69fd2dd into joomla:staging Jul 23, 2016
@wilsonge wilsonge added this to the Joomla 3.6.1 milestone Jul 23, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 23, 2016
@andrepereiradasilva andrepereiradasilva deleted the associations-on-install branch July 23, 2016 12:47
@andrepereiradasilva andrepereiradasilva mentioned this pull request Jul 23, 2016
Merged
@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Jul 23, 2016

@wilsonge please revert this and change milestone to 3.6.2

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Jul 23, 2016

Why?

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Jul 23, 2016

because of new necessary lang string
#11263

@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Jul 23, 2016

Rather than revert I've done a very tacky fix of making it a generic error string (see e83f468) and we will ensure #11263 is merged for 3.6.2

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Jul 23, 2016

OK. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla 3.6.1

Development

Successfully merging this pull request may close these issues.

6 participants

@andrepereiradasilva @infograf768 @dgrammatiko @brianteeman @wilsonge @joomla-cms-bot