[protostar offline] use JAuthenticationHelper for getting the available Two Factor Auth Methods#11667
Merged
wilsonge merged 1 commit intojoomla:stagingfrom Aug 19, 2016
Merged
Conversation
…in protostar offline template
Contributor
|
Merged on review |
ggppdk
pushed a commit
to ggppdk/joomla-cms
that referenced
this pull request
Aug 19, 2016
…in protostar offline template (joomla#11667)
This was referenced Aug 20, 2016
roland-d
pushed a commit
to roland-d/joomla-cms
that referenced
this pull request
Sep 11, 2016
…in protostar offline template (joomla#11667)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Use JAuthenticationHelper for getting the available TwoFactorMethods in protostar template.
Testing Instructions
Mainly code review.
But you can also apply patch, enable two factor authentication, set site to offline with protostar template and check the "secret key" input is there.
Documentation Changes Required
None.