Language filter alternate meta tags default value should be 1#11642

Merged

wilsonge merged 3 commits intojoomla:stagingfrom

andrepereiradasilva:patch-9

Aug 19, 2016

Contributor

andrepereiradasilva commented Aug 17, 2016 •

edited by jeckodevelopment

Loading

Summary of Changes

Language filter alternate meta tags parameter default is 1 so make it 1 as default also in the code.

Testing Instructions

Code review.
See also https://github.com/joomla/joomla-cms/blob/staging/plugins/system/languagefilter/languagefilter.xml#L57

Documentation Changes Required

None.


          Language filter alternate meta default is 1

99d36d0

joomla-cms-bot added the PR-staging label


          Update languagefilter.php

13c663f

Member

infograf768 commented Aug 18, 2016

@andrepereiradasilva
Associations or not, the alternate should display when we are on the home pages.
Example

<link href="http://localhost:8888/gsocmulti/it/" rel="alternate" hreflang="it-IT" />
    <link href="http://localhost:8888/gsocmulti/fr/" rel="alternate" hreflang="fr-FR" />
    <link href="http://localhost:8888/gsocmulti/" rel="alternate" hreflang="en-GB" />

Member

infograf768 commented Aug 18, 2016 •

edited

Loading

This means imho we should change the showon as alternate meta tags and x-default fields should display even when no associations. It also means a lang change for the string
PLG_SYSTEM_LANGUAGEFILTER_FIELD_ALTERNATE_META_DESC


          Update languagefilter.php

06e4a54

Contributor Author

andrepereiradasilva commented Aug 18, 2016

Associations or not, the alternate should display when we are on the home pages.

Ok. removed that part from the code. now just sets the default as innitially

This means imho we should change the showon as alternate meta tags and x-default fields should display even when no associations. It also means a lang change for the string PLG_SYSTEM_LANGUAGEFILTER_FIELD_ALTERNATE_META_DESC

please make a PR for that.

please test

Member

infograf768 commented Aug 18, 2016

I have tested this item ✅ successfully on 06e4a54

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11642.}

Member

infograf768 commented Aug 18, 2016

will make pr

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11642.}

Member

jeckodevelopment commented Aug 18, 2016

I have tested this item ✅ successfully on 06e4a54

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11642.}

Member

jeckodevelopment commented Aug 18, 2016

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11642.}

joomla-cms-bot added the RTC label

Member

infograf768 commented Aug 19, 2016

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11642.}

wilsonge merged commit 87ce1ff into joomla:staging

wilsonge added this to the Joomla 3.6.3 milestone

joomla-cms-bot removed the RTC label

andrepereiradasilva deleted the patch-9 branch

August 19, 2016 13:51

ggppdk pushed a commit to ggppdk/joomla-cms that referenced this pull request


          Language filter alternate meta tags default value should be 1 (joomla…

…#11642)

* Language filter alternate meta default is 1

* Update languagefilter.php

* Update languagefilter.php

roland-d pushed a commit to roland-d/joomla-cms that referenced this pull request


          Language filter alternate meta tags default value should be 1 (joomla…

e70ce9d

…#11642)

* Language filter alternate meta default is 1

* Update languagefilter.php

* Update languagefilter.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet