Skip to content

Language filter alternate meta tags default value should be 1#11642

Merged
wilsonge merged 3 commits intojoomla:stagingfrom
andrepereiradasilva:patch-9
Aug 19, 2016
Merged

Language filter alternate meta tags default value should be 1#11642
wilsonge merged 3 commits intojoomla:stagingfrom
andrepereiradasilva:patch-9

Conversation

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

@andrepereiradasilva andrepereiradasilva commented Aug 17, 2016

Summary of Changes

Language filter alternate meta tags parameter default is 1 so make it 1 as default also in the code.

Testing Instructions

Code review.
See also https://github.com/joomla/joomla-cms/blob/staging/plugins/system/languagefilter/languagefilter.xml#L57

Documentation Changes Required

None.

@infograf768
Copy link
Copy Markdown
Member

@andrepereiradasilva
Associations or not, the alternate should display when we are on the home pages.
Example

<link href="http://localhost:8888/gsocmulti/it/" rel="alternate" hreflang="it-IT" />
    <link href="http://localhost:8888/gsocmulti/fr/" rel="alternate" hreflang="fr-FR" />
    <link href="http://localhost:8888/gsocmulti/" rel="alternate" hreflang="en-GB" />

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Aug 18, 2016

This means imho we should change the showon as alternate meta tags and x-default fields should display even when no associations. It also means a lang change for the string
PLG_SYSTEM_LANGUAGEFILTER_FIELD_ALTERNATE_META_DESC

@andrepereiradasilva
Copy link
Copy Markdown
Contributor Author

Associations or not, the alternate should display when we are on the home pages.

Ok. removed that part from the code. now just sets the default as innitially

This means imho we should change the showon as alternate meta tags and x-default fields should display even when no associations. It also means a lang change for the string PLG_SYSTEM_LANGUAGEFILTER_FIELD_ALTERNATE_META_DESC

please make a PR for that.

please test

@infograf768
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on 06e4a54


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11642.

@infograf768
Copy link
Copy Markdown
Member

will make pr


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11642.

@jeckodevelopment
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on 06e4a54


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11642.

@jeckodevelopment
Copy link
Copy Markdown
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11642.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 18, 2016
@infograf768
Copy link
Copy Markdown
Member

See #11663


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11642.

@wilsonge wilsonge merged commit 87ce1ff into joomla:staging Aug 19, 2016
@wilsonge wilsonge added this to the Joomla 3.6.3 milestone Aug 19, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 19, 2016
@andrepereiradasilva andrepereiradasilva deleted the patch-9 branch August 19, 2016 13:51
ggppdk pushed a commit to ggppdk/joomla-cms that referenced this pull request Aug 19, 2016
…#11642)

* Language filter alternate meta default is 1

* Update languagefilter.php

* Update languagefilter.php
roland-d pushed a commit to roland-d/joomla-cms that referenced this pull request Sep 11, 2016
…#11642)

* Language filter alternate meta default is 1

* Update languagefilter.php

* Update languagefilter.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants