Upgrade EUI to v27.4.0 by thompsongl · Pull Request #74004 · elastic/kibana

thompsongl · 2020-07-31T20:43:30Z

Summary

v26.3.1 ⏩ v27.4.0

Changed underlying list virtualization library. Some EuiComboBox and EuiFilter* lists will technically have one fewer item in the DOM on initial load, although no real change occurs because the now-absent item was not visible initially without scrolling.
Changed underlying focus trap library. Better screen reader and keyboard navigation experience
Exported types from '@elastic/eui/lib/test'

Nearly all non-snapshot changes relate to the first two points. EuiSelectable and EuiComboBox have increased virtualization (in places where the list has virtualized scrolling) which results in fewer items initially selectable by DOM (and Selenium) methods. Also, slight DOM rearrangement resulted in data-test-subj .at()/.eq() index changes.

Snapshot updates are largely related to an internal change to the structure of EuiButton (and variants), resulting in subcomponent naming and className churn. Also, buttons in a loading state (isLoading prop), now render a disabled button to prevent clicks.

`27.4.0`

Added customOptionText prop to EuiComboBox (#3811)

Bug fixes

Improve EuiDataGrid Chrome rendering performance in full screen (#3726)
Removed @elastic/eui/src-docs entries from published eui.d.ts (#3856)

`27.3.1`

Bug fixes

Fixed bug in all input fields placeholders in Safari that weren't vertically centered (#3809)
Removed pointer-events: none in both EuiButton & EuiButtonEmpty to not override the pointer-events: auto in the button mixin euiButtonContentDisabled (#3824)
Fixed bug in EuiPagination showing wrong page count when compressed prop is true. (#3827)
Fixed bug in EUI's input field components where their inputRef couldn't be a RefObject (#3822)
Moved react-view and html-format to be devDependencies (#3828)
Fixed EuiComboBox keyboard selection when sortMatchesBy=startsWith (#3823)
Fixed EuiCodeEditor not exiting edit mode with esc when enableLiveAutocompletion=true (#3833)
Fixed issue where EuiDataGrid's cell expansion popover would sometimes render as a scrollable element (#3832)

`27.3.0`

Added possibility to hide "Rows per page" select in EuiDataGrid (#3700)
Updated lodash to v4.17.19 (#3764)
Added returnKey glyph to EuiIcon (#3783)
Added type prop to EuiFieldPassword to support toggling of obfuscation (#3751)

Bug fixes

Fixed bug in EuiDataGrid not calculating the width correctly (#3789)
Fixed EuiComboBox marking some very long inputs as invalid (#3797)

`27.2.0`

Added analyzeEvent glyph in EuiIcon (#3729)
Updated EuiComboBox to allow the options list to open for single selection custom options (#3706)
Added useEuiI18n hook for localization (#3749)
Added a hit enter badge to EuiComboBox when focusing an option and for empty states that allow pressing enter (#3782)

Bug fixes

Fixed EuiComboBox always showing a scrollbar (#3744)
Replaced react-focus-lock with react-focus-on (#3631)
Fixed errors in EuiSuperDatePicker related to invalid and null date formatting (#3750)
Fixed type definitions for findTestSubject and takeMountedSnapshot (#3763)
Fixed EuiComboBox not allowing clicks on previously virtualized items when inside of EuiFormRow (#3784)
Removed [Space] as a way to select options in EuiSelectable (#3784)
Fixed type definition for windowProps in EuiSelectable (#3787)

`27.1.0`

Added titleElement and descriptionElement props to EuiStat (#3693)
Updated securityAnalyticsApp app icon (#3720)
Removed src/test and @types/enzyme references from eui.d.ts (#3715)
Added index.d.ts file to lib/test and es/test (#3715)
Added descriptionFlexItemProps and fieldFlexItemProps props to EuiDescribedFormGroup (#3717)
Expanded EuiBasicTable's default action's name configuration to accept a function that returns a React node (#3739)
Added internal use only button building blocks for reusability in other button components (#3730)

`27.0.0`

Added paddingSize prop to EuiCard (#3638)
Added isClearable and placeholder options to EuiColorPicker (#3689)
Added SASS helper files for EUI theme globals (#3691)
Add label, labelProps and valueText props to EuiProgress (#3661)

Bug fixes

Fixed a bug in EuiResizableContainer preventing nested containers (#3699)
Fixed a bug in EuiResizableContainer preventing resizing by arrow keys in some cases (#3699)
Fixed EuiHorizontalSteps rendering over EuiHeader (#3707)
Fixed bug where EuiSuperSelect lost focus after a value selection (#3734)

Breaking changes

Significant accessibility refactor of EuiSelectable (#3169)
- react-virtualized replaced with react-window
- virtualizedProps on EuiSelectableOptionsList renamed to windowProps
- Removed rootId and added makeOptionId, listId, and setActiveOptionIndex to EuiSelectableList
- Added listId to EuiSelectableSearch
- options passed into EuiSelectable cannot have an id
- Requires an onChange to be passed into EuiSelectableSearch

alisonelizabeth

ES UI changes LGTM.

...ins/canvas/public/components/asset_manager/__stories__/__snapshots__/asset.stories.storyshot

poffdeluxe

Canvas changes lgtm

joshdover

Platform changes LGTM

chrisronline

LGTM for stack monitoring

XavierM

Security Solution approve this PR ;)

shahzad31

Uptime changes LGTM !!

cauemarcondes

APM changes LGTM

thompsongl · 2020-08-13T14:59:10Z

@elasticmachine merge upstream

…i/27

timroes

Rewviewed code of Kibana App ownership only. Code LGTM

thompsongl · 2020-08-14T14:31:16Z

@elasticmachine merge upstream

kibanamachine · 2020-08-14T16:27:48Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: ed1a06e

Build metrics

async chunks size

id	value	diff	baseline
rollup	330.5KB	-2.0B	330.5KB
securitySolution	7.2MB	+620.0B	7.2MB
watcher	602.9KB	-2.0B	602.9KB
total		+616.0B

page load bundle size

id	value	diff	baseline
visTypeTimeseries	280.9KB	+476.0B	280.5KB

History

💚 Build #67952 succeeded f20c38b
💔 Build #67940 failed 6862a85
💚 Build #67773 succeeded e619345
💚 Build #67550 succeeded 548590b
💚 Build #67404 succeeded 7530215

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* eui to 27.1.0 * eui to 27.2.0 * buttoniconside type * euiselectable type * update onScroll callback and polyfill size references * findTestSubject ts * buttoncontent and collapsiblenav src snapshot updates * update prop retrieval * xpack snapshots * jest updates * type fixes * more snapshots * virtual list changes * more virtualization changes * merge * fix functional tests * data-test-subj for indexPatter-switcher * storyshots * eui to 27.3.1 * Fix unit tests * Fix broken unit test * Updated snapshots * Fixed types * search for value in euiselectable before selection * select the correct element * mock virtualized dep * ts fix * reinstate storyshot * ts fix Co-authored-by: Chandler Prall <chandler.prall@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* eui to 27.1.0 * eui to 27.2.0 * buttoniconside type * euiselectable type * update onScroll callback and polyfill size references * findTestSubject ts * buttoncontent and collapsiblenav src snapshot updates * update prop retrieval * xpack snapshots * jest updates * type fixes * more snapshots * virtual list changes * more virtualization changes * merge * fix functional tests * data-test-subj for indexPatter-switcher * storyshots * eui to 27.3.1 * Fix unit tests * Fix broken unit test * Updated snapshots * Fixed types * search for value in euiselectable before selection * select the correct element * mock virtualized dep * ts fix * reinstate storyshot * ts fix Co-authored-by: Chandler Prall <chandler.prall@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Chandler Prall <chandler.prall@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

thompsongl added 29 commits July 21, 2020 10:39

eui to 27.1.0

56f847d

eui to 27.2.0

6e88169

buttoniconside type

4d1fb82

euiselectable type

006b6fd

update onScroll callback and polyfill size references

1bb3fa0

findTestSubject ts

d97395c

buttoncontent and collapsiblenav src snapshot updates

9aa61d4

update prop retrieval

5ccbd18

xpack snapshots

810d4c1

jest updates

8cb46b5

Merge branch 'master' into eui/27

92e92e5

Merge branch 'master' into eui/27

e254e4c

type fixes

d91ca43

Merge branch 'master' into eui/27

5d20471

more snapshots

5bfcae2

Merge branch 'master' into eui/27

74ba69d

virtual list changes

b9ba0b1

more virtualization changes

a17cc17

Merge branch 'master' into eui/27

3912ad2

merge

2537aa9

Merge branch 'master' into eui/27

b1d6710

fix functional tests

79cc7fe

Merge branch 'master' into eui/27

9b644b2

Merge branch 'master' into eui/27

5b72e28

data-test-subj for indexPatter-switcher

2f84eed

Merge branch 'master' into eui/27

954e63c

storyshots

2791b0c

eui to 27.3.1

6b92ad9

Merge branch 'master' into eui/27

735fb2e

thompsongl added the v8.0.0 label Jul 31, 2020

tylersmalley approved these changes Aug 11, 2020

View reviewed changes

alisonelizabeth approved these changes Aug 11, 2020

View reviewed changes

poffdeluxe reviewed Aug 11, 2020

View reviewed changes

...ins/canvas/public/components/asset_manager/__stories__/__snapshots__/asset.stories.storyshot Show resolved Hide resolved

thompsongl added 2 commits August 11, 2020 09:21

Merge branch 'master' into eui/27

382c052

reinstate storyshot

548590b

thompsongl requested review from poffdeluxe and shahzad31 August 11, 2020 17:26

thompsongl mentioned this pull request Aug 11, 2020

[Logs UI] [Metrics UI] Keyboard control audit #74108

Closed

poffdeluxe approved these changes Aug 11, 2020

View reviewed changes

joshdover approved these changes Aug 12, 2020

View reviewed changes

chrisronline approved these changes Aug 12, 2020

View reviewed changes

Merge branch 'master' into eui/27

e619345

XavierM approved these changes Aug 12, 2020

View reviewed changes

shahzad31 approved these changes Aug 13, 2020

View reviewed changes

Merge branch 'master' into eui/27

6587e55

cauemarcondes approved these changes Aug 13, 2020

View reviewed changes

elasticmachine and others added 3 commits August 13, 2020 08:59

Merge branch 'master' into eui/27

6862a85

Merge branch 'eui/27' of https://github.com/thompsongl/kibana into eu…

331de6a

…i/27

ts fix

f20c38b

timroes approved these changes Aug 14, 2020

View reviewed changes

Merge branch 'master' into eui/27

ed1a06e

thompsongl merged commit bbee1f9 into elastic:master Aug 14, 2020

thompsongl mentioned this pull request Aug 14, 2020

[7.x] Upgrade EUI to v27.4.0 (#74004) #75064

Merged

spalger mentioned this pull request Aug 15, 2020

[jest] temporarily extend default test timeout #75118

Merged

thompsongl mentioned this pull request Aug 17, 2020

Add test-env mock for EuiFocusTrap elastic/eui#3930

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade EUI to v27.4.0#74004

Upgrade EUI to v27.4.0#74004
thompsongl merged 49 commits intoelastic:masterfrom
thompsongl:eui/27

thompsongl commented Jul 31, 2020 •

edited

Loading

Uh oh!

alisonelizabeth left a comment

Uh oh!

Uh oh!

poffdeluxe left a comment

Uh oh!

joshdover left a comment

Uh oh!

chrisronline left a comment

Uh oh!

XavierM left a comment •

edited

Loading

Uh oh!

shahzad31 left a comment

Uh oh!

cauemarcondes left a comment

Uh oh!

thompsongl commented Aug 13, 2020

Uh oh!

timroes left a comment

Uh oh!

thompsongl commented Aug 14, 2020

Uh oh!

kibanamachine commented Aug 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

Conversation

thompsongl commented Jul 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

27.4.0

27.3.1

27.3.0

27.2.0

27.1.0

27.0.0

Uh oh!

alisonelizabeth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

poffdeluxe left a comment

Choose a reason for hiding this comment

Uh oh!

joshdover left a comment

Choose a reason for hiding this comment

Uh oh!

chrisronline left a comment

Choose a reason for hiding this comment

Uh oh!

XavierM left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shahzad31 left a comment

Choose a reason for hiding this comment

Uh oh!

cauemarcondes left a comment

Choose a reason for hiding this comment

Uh oh!

thompsongl commented Aug 13, 2020

Uh oh!

timroes left a comment

Choose a reason for hiding this comment

Uh oh!

thompsongl commented Aug 14, 2020

Uh oh!

kibanamachine commented Aug 14, 2020

💚 Build Succeeded

Build metrics

async chunks size

page load bundle size

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

thompsongl commented Jul 31, 2020 •

edited

Loading

`27.4.0`

`27.3.1`

`27.3.0`

`27.2.0`

`27.1.0`

`27.0.0`

XavierM left a comment •

edited

Loading