Fix EuiHorizontalSteps rendering over EuiHeader#3707
Merged
elizabetdev merged 2 commits intoelastic:masterfrom Jul 8, 2020
Merged
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3707/ |
chandlerprall
approved these changes
Jul 8, 2020
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
SCSS change LGTM, and it's function continues to match the existing comment in the code; Tested the z-index change in the provided code sandbox
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes #3704.
The EuiHorizontalSteps numbers were rendering over a fixed EuiHeader: https://codesandbox.io/s/brave-lake-s4r7f?file=/index.js
Fix
To ensure the connecting lines stay behind the number a z-index of
$euiZLevel0was given to the lines and the numbers received a z-index of$euiZLevel1. But$euiZLevel1is too high1000.Because we only want to make the lines saying behind the number it makes sense to give a z-index to numbers just a little bit higher than the lines. So
$euiZLevel0 + 1seems a good solution to me.Checklist
[ ] Check against all themes for compatibility in both light and dark modes[ ] Checked in mobile[ ] Checked in IE11 and Firefox[ ] Props have proper autodocs[ ] Added documentation[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes