Remove src-docs files from eui.d.ts modules#3856
Merged
chandlerprall merged 3 commits intoelastic:masterfrom Aug 3, 2020
Merged
Remove src-docs files from eui.d.ts modules#3856chandlerprall merged 3 commits intoelastic:masterfrom
chandlerprall merged 3 commits intoelastic:masterfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3856/ |
pugnascotia
approved these changes
Aug 3, 2020
Contributor
pugnascotia
left a comment
There was a problem hiding this comment.
Built locally to check, LGTM
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3856/ |
nyurik
pushed a commit
that referenced
this pull request
Aug 18, 2020
* Remove src-docs files from eui.d.ts modules * changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3849 by configuring our eui.d.ts generation to exclude
src-docs/**/*Tested by running
node scripts/dtsgenerator.jsand inspecting the generated file.I also verified all there are no other entires outside of the src path with regex search
module '@elastic/eui/(?!src)- with the sole exception of@elastic/eui/dist/eui_theme_*.jsonwhich is expected to be present.### Checklist