Merged
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3691/ |
2 similar comments
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3691/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3691/ |
snide
approved these changes
Jul 2, 2020
Contributor
snide
left a comment
There was a problem hiding this comment.
Read through this and checked the code / compile. Safe to merge!
a76f1aa to
7f4019b
Compare
Contributor
Author
|
Good thing I checked this in Kibana, I had multiple paths wrong. All good now! All 4 themes properly compile with the proper globals. |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3691/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SASS Globals
Consuming apps that want to use our invisibles have to import the functions, mixins, and variable index files separately because importing the
global_styles/index.scssfile comes with the reset and animations (non-invisibles) that would be repeated for each import.This is too much for the apps to remember, so I made a helper file for the default and Amsterdam themes.
Checklist
[ ] Checked in mobile[ ] Checked in IE11 and Firefox[ ] Props have proper autodocs[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes