[EuiSelectable+EuiComboBox] recent regresion fixes#3784
Merged
thompsongl merged 4 commits intoelastic:masterfrom Jul 22, 2020
Merged
[EuiSelectable+EuiComboBox] recent regresion fixes#3784thompsongl merged 4 commits intoelastic:masterfrom
thompsongl merged 4 commits intoelastic:masterfrom
Conversation
chandlerprall
suggested changes
Jul 22, 2020
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
Changelog formatting nit-picks but otherwise this LGTM!
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3784/ |
Co-authored-by: Chandler Prall <chandler.prall@gmail.com>
cchaos
approved these changes
Jul 22, 2020
Contributor
cchaos
left a comment
There was a problem hiding this comment.
Tested for both original bugs which are both fixed! Thanks for the quick PR!
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3784/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two regressions caused by the recent selectable-a11y branch.
react-windowlibrary replacingreact-virtualized, this in conjunction with EuiFormRow was causing an extra rerender on click of virtualized elements which broke clicking... Adding a check in EuiFormRow for if the thing needs to rerender fixes it.Checklist
- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests- [ ] Props have proper autodocs- [ ] Added documentation- [ ] Checked in IE11- [ ] Check against all themes for compatibility in both light and dark modes