Skip to content

[EuiSelectable] Partial ListProps type#3787

Merged
thompsongl merged 5 commits intoelastic:masterfrom
thompsongl:windowprops-partial
Jul 22, 2020
Merged

[EuiSelectable] Partial ListProps type#3787
thompsongl merged 5 commits intoelastic:masterfrom
thompsongl:windowprops-partial

Conversation

@thompsongl
Copy link
Copy Markdown
Contributor

@thompsongl thompsongl commented Jul 22, 2020

Summary

The ListProps interface applies to the FixedSizeList component, which both come fromreact-window. EUI uses FixedSizeList and applies all required props. EUI's layered-on windowProps prop allows consumers to pass any additional props directly to FixedSizeList, but intended to do so on an optional basis.

The solution is to add Partial<>

This change is required for type_check passing in Kibana.

Checklist

- [ ] Check against all themes for compatibility in both light and dark modes
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox

  • Props have proper autodocs

- [ ] Added documentation
- [ ] Checked Code Sandbox works for the any docs examples

  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately

- [ ] Checked for accessibility including keyboard-only and screenreader modes

  • A changelog entry exists and is marked appropriately

Copy link
Copy Markdown
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kibanamachine
Copy link
Copy Markdown

Preview documentation changes for this PR: https://eui.elastic.co/pr_3787/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants