Fixed input fields placeholders not vertically centered in Safari#3809
Merged
elizabetdev merged 4 commits intoelastic:masterfrom Jul 29, 2020
Merged
Fixed input fields placeholders not vertically centered in Safari#3809elizabetdev merged 4 commits intoelastic:masterfrom
elizabetdev merged 4 commits intoelastic:masterfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3809/ |
chandlerprall
approved these changes
Jul 29, 2020
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
LGTM! Verified fix in Safari, tested for any regression/unwanted changes in Chrome/FF/Edge
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3809/ |
9dce793 to
fb23633
Compare
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3809/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes #3796. It fixes the inputs placeholders in Safari that weren't vertically centered.
Checklist
[ ] Checked in mobile[ ] Props have proper autodocs[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes