Add returnKey glyph to EuiIcon#3783
Merged
elizabetdev merged 9 commits intoelastic:masterfrom Jul 23, 2020
Merged
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3783/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3783/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3783/ |
Contributor
Author
|
@chaos the design is now updated with what we discussed:
|
5 tasks
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3783/ |
cchaos
approved these changes
Jul 23, 2020
Contributor
cchaos
left a comment
There was a problem hiding this comment.
🎉 Looks great. Thanks for making those small changes. Looks like you still have the return.js file lingering, but other than that, 👍
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3783/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a
returnKeyglyph to EuiIcon. The icon is a requirement for #3782. The main idea is to use it inside a badge to indicate users that they can press an enter key to perform an action.Design
Dark and light themes
Icon being used in a badge
Checklist
[ ] Checked in mobile[ ] Props have proper autodocs[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Checked for breaking changes and labeled appropriately