Remove src/test/* from type definitions file#3715
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3715/ |
|
Yep, this is a better approach. Tested in Kibana without altering |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3715/ |
|
The generated files don't look correct, all of the |
Good catch. Updated to include full module names. |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3715/ |
|
jenkins test this "PUPPETEER_SKIP_CHROMIUM_DOWNLOAD" |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3715/ |
Summary
Closes #3709 by removing
src/test/*files fromeui.d.ts. Additionally generates newlib/test/index.d.tsandes/test/index.d.tsfiles specifically for consumers who usetestdirectory utilities.As
src/testis not formally part of EUI's API,testimports occur fromliboresand are@ts-ignoreed. This PR is an enhancement for those imports, as types will automatically be picked up when importing from@elastic/eui/[lib, es]/test.Removing
src/testfromeui.d.tsallows for@types/enzymeto be moved back to devDep status. Use oflib/testores/testassumes your project maintains its own@types/enzymedependencyChecklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes