[EuiComboBox] Fix keyboard selection when sortMatchesBy=startsWith#3823
Merged
thompsongl merged 4 commits intoelastic:masterfrom Jul 30, 2020
Merged
[EuiComboBox] Fix keyboard selection when sortMatchesBy=startsWith#3823thompsongl merged 4 commits intoelastic:masterfrom
thompsongl merged 4 commits intoelastic:masterfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3823/ |
chandlerprall
approved these changes
Jul 30, 2020
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM! Tested with the published docs' Sorting matches example, where the bug has been reproducible. Also tested examples without startsWith to verify those still function as expected.
Thanks for adding the test case!
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3823/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3812, in which using the keyboard to select an option in EuiComboBox when
sortMatchesBy=startsWithwould select the wrong option.The problem arose from the sort logic only occurring during the render function, bypassing the state store that the keyboard logic uses to track active options.
This change moves the logic to the central
getMatchingOptionsfunction, which updates component state.Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation